Support lifecycle hooks in devcontainer features #1881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parse and save lifecycle hooks from features into image metadata. Once available as metadata, it seems like they are correctly used already. Tests are missing, I do not have the capacity to add them. Would appreciate maintainer help with that. Fixes: loft-sh#1880
|
ping @pascalbreuninger, does this repository accept contributions? |
|
👍 I can confirm that this patch results in lifecycle hooks running correctly for my features. I applied to to the 0.6.15 commit and have been using for the past few days (mostly with the docker/podman provider). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse and save lifecycle hooks from features into image metadata. Once available as metadata, it seems like they are correctly used already.
Tests are missing, I do not have the capacity to add them. Would appreciate maintainer help with that.
Fixes: #1880