From 9a43dc94f5837cda85dcd286179109ddaa4df15f Mon Sep 17 00:00:00 2001 From: Loic Diridollou Date: Thu, 8 Aug 2024 18:08:04 -0700 Subject: [PATCH 01/29] Test issue --- .github/workflows/optional.yml | 121 +++++++++++++---------- .github/workflows/{test.yml => test.txt} | 0 2 files changed, 71 insertions(+), 50 deletions(-) rename .github/workflows/{test.yml => test.txt} (100%) diff --git a/.github/workflows/optional.yml b/.github/workflows/optional.yml index 4cbeccc03..f7e724868 100644 --- a/.github/workflows/optional.yml +++ b/.github/workflows/optional.yml @@ -1,56 +1,77 @@ -name: 'Optional' - +name: Comment Commands on: - push: - branches: - - main - workflow_dispatch: - -jobs: - nightly: - runs-on: ubuntu-latest - timeout-minutes: 10 - - steps: - - uses: actions/checkout@v3 - - - name: Install project dependencies - uses: ./.github/setup - with: - os: ubuntu-latest - python-version: '3.11' - - - name: Run pytest (against pandas nightly) - run: poetry run poe pytest --nightly + issue_comment: + types: created - mypy_nightly: - runs-on: ubuntu-latest - timeout-minutes: 10 - - steps: - - uses: actions/checkout@v3 - - - name: Install project dependencies - uses: ./.github/setup - with: - os: ubuntu-latest - python-version: '3.11' +permissions: + contents: read + issues: write + pull-requests: write - - name: Run mypy tests with mypy nightly - run: poetry run poe mypy --mypy_nightly - - pyright_strict: +jobs: + issue_assign: runs-on: ubuntu-latest - timeout-minutes: 10 - + if: (!github.event.issue.pull_request) && github.event.comment.body == 'take' + concurrency: + group: ${{ github.actor }}-issue-assign steps: - - uses: actions/checkout@v3 - - - name: Install project dependencies - uses: ./.github/setup - with: - os: ubuntu-latest - python-version: '3.11' + - run: | + echo "Assigning issue ${{ github.event.issue.number }} to ${{ github.event.comment.user.login }}" - - name: Run pyright tests with full strict mode - run: poetry run poe pyright_strict +# +# name: 'Optional' +# +# on: +# push: +# branches: +# - main +# workflow_dispatch: +# +# jobs: +# nightly: +# runs-on: ubuntu-latest +# timeout-minutes: 10 +# +# steps: +# - uses: actions/checkout@v3 +# +# - name: Install project dependencies +# uses: ./.github/setup +# with: +# os: ubuntu-latest +# python-version: '3.11' +# +# - name: Run pytest (against pandas nightly) +# run: poetry run poe pytest --nightly +# +# mypy_nightly: +# runs-on: ubuntu-latest +# timeout-minutes: 10 +# +# steps: +# - uses: actions/checkout@v3 +# +# - name: Install project dependencies +# uses: ./.github/setup +# with: +# os: ubuntu-latest +# python-version: '3.11' +# +# - name: Run mypy tests with mypy nightly +# run: poetry run poe mypy --mypy_nightly +# +# pyright_strict: +# runs-on: ubuntu-latest +# timeout-minutes: 10 +# +# steps: +# - uses: actions/checkout@v3 +# +# - name: Install project dependencies +# uses: ./.github/setup +# with: +# os: ubuntu-latest +# python-version: '3.11' +# +# - name: Run pyright tests with full strict mode +# run: poetry run poe pyright_strict diff --git a/.github/workflows/test.yml b/.github/workflows/test.txt similarity index 100% rename from .github/workflows/test.yml rename to .github/workflows/test.txt From ba81f961f73e874d5fbf1d0bee680d53a6e4a96d Mon Sep 17 00:00:00 2001 From: Loic Diridollou Date: Thu, 8 Aug 2024 18:10:21 -0700 Subject: [PATCH 02/29] Adding new file --- new_file.txt | 1 + 1 file changed, 1 insertion(+) create mode 100644 new_file.txt diff --git a/new_file.txt b/new_file.txt new file mode 100644 index 000000000..9daeafb98 --- /dev/null +++ b/new_file.txt @@ -0,0 +1 @@ +test From 82e9a03d224ec966f0f224fba1d24d6cf2f40601 Mon Sep 17 00:00:00 2001 From: Loic Diridollou Date: Thu, 8 Aug 2024 18:15:46 -0700 Subject: [PATCH 03/29] Update optional.yml --- .github/workflows/optional.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/optional.yml b/.github/workflows/optional.yml index f7e724868..432b510bb 100644 --- a/.github/workflows/optional.yml +++ b/.github/workflows/optional.yml @@ -11,9 +11,7 @@ permissions: jobs: issue_assign: runs-on: ubuntu-latest - if: (!github.event.issue.pull_request) && github.event.comment.body == 'take' - concurrency: - group: ${{ github.actor }}-issue-assign + if: (github.event.issue.pull_request) && github.event.comment.body == 'take' steps: - run: | echo "Assigning issue ${{ github.event.issue.number }} to ${{ github.event.comment.user.login }}" From acd9dc20c06a9c4daa3f9e733e5fe0df2d711266 Mon Sep 17 00:00:00 2001 From: Loic Diridollou Date: Thu, 8 Aug 2024 21:00:41 -0700 Subject: [PATCH 04/29] Test --- .github/actions/optional.yml | 77 ++++++++++++++++++++++++++ .github/workflows/comment_commands.yml | 61 ++++++++++++++++++++ 2 files changed, 138 insertions(+) create mode 100644 .github/actions/optional.yml create mode 100644 .github/workflows/comment_commands.yml diff --git a/.github/actions/optional.yml b/.github/actions/optional.yml new file mode 100644 index 000000000..f7e724868 --- /dev/null +++ b/.github/actions/optional.yml @@ -0,0 +1,77 @@ +name: Comment Commands +on: + issue_comment: + types: created + +permissions: + contents: read + issues: write + pull-requests: write + +jobs: + issue_assign: + runs-on: ubuntu-latest + if: (!github.event.issue.pull_request) && github.event.comment.body == 'take' + concurrency: + group: ${{ github.actor }}-issue-assign + steps: + - run: | + echo "Assigning issue ${{ github.event.issue.number }} to ${{ github.event.comment.user.login }}" + +# +# name: 'Optional' +# +# on: +# push: +# branches: +# - main +# workflow_dispatch: +# +# jobs: +# nightly: +# runs-on: ubuntu-latest +# timeout-minutes: 10 +# +# steps: +# - uses: actions/checkout@v3 +# +# - name: Install project dependencies +# uses: ./.github/setup +# with: +# os: ubuntu-latest +# python-version: '3.11' +# +# - name: Run pytest (against pandas nightly) +# run: poetry run poe pytest --nightly +# +# mypy_nightly: +# runs-on: ubuntu-latest +# timeout-minutes: 10 +# +# steps: +# - uses: actions/checkout@v3 +# +# - name: Install project dependencies +# uses: ./.github/setup +# with: +# os: ubuntu-latest +# python-version: '3.11' +# +# - name: Run mypy tests with mypy nightly +# run: poetry run poe mypy --mypy_nightly +# +# pyright_strict: +# runs-on: ubuntu-latest +# timeout-minutes: 10 +# +# steps: +# - uses: actions/checkout@v3 +# +# - name: Install project dependencies +# uses: ./.github/setup +# with: +# os: ubuntu-latest +# python-version: '3.11' +# +# - name: Run pyright tests with full strict mode +# run: poetry run poe pyright_strict diff --git a/.github/workflows/comment_commands.yml b/.github/workflows/comment_commands.yml new file mode 100644 index 000000000..741e456c7 --- /dev/null +++ b/.github/workflows/comment_commands.yml @@ -0,0 +1,61 @@ +name: Comment Commands +on: + issue_comment: + types: created, edited + +permissions: + contents: read + issues: write + pull-requests: write + +jobs: + nightly: + runs-on: ubuntu-latest + timeout-minutes: 10 + if: (!github.event.issue.pull_request) && github.event.comment.body == '/nightly' + + steps: + - uses: actions/checkout@v3 + + - name: Install project dependencies + uses: ./.github/setup + with: + os: ubuntu-latest + python-version: "3.11" + + - name: Run pytest (against pandas nightly) + run: poetry run poe pytest --nightly + + mypy_nightly: + runs-on: ubuntu-latest + timeout-minutes: 10 + if: (github.event.issue.pull_request) && github.event.comment.body == '/mypy_nightly' + + steps: + - uses: actions/checkout@v3 + + - name: Install project dependencies + uses: ./.github/setup + with: + os: ubuntu-latest + python-version: "3.11" + + - name: Run mypy tests with mypy nightly + run: poetry run poe mypy --mypy_nightly + + pyright_strict: + runs-on: ubuntu-latest + timeout-minutes: 10 + if: (github.event.issue.pull_request) && github.event.comment.body == '/pyright_strict' + + steps: + - uses: actions/checkout@v3 + + - name: Install project dependencies + uses: ./.github/setup + with: + os: ubuntu-latest + python-version: "3.11" + + - name: Run pyright tests with full strict mode + run: poetry run poe pyright_strict From a04bdea4894efa703e00b5feeecfa98cfa8a4457 Mon Sep 17 00:00:00 2001 From: Loic Diridollou Date: Thu, 8 Aug 2024 21:01:44 -0700 Subject: [PATCH 05/29] Test --- .github/actions/optional.yml | 77 ------------------------------------ 1 file changed, 77 deletions(-) delete mode 100644 .github/actions/optional.yml diff --git a/.github/actions/optional.yml b/.github/actions/optional.yml deleted file mode 100644 index f7e724868..000000000 --- a/.github/actions/optional.yml +++ /dev/null @@ -1,77 +0,0 @@ -name: Comment Commands -on: - issue_comment: - types: created - -permissions: - contents: read - issues: write - pull-requests: write - -jobs: - issue_assign: - runs-on: ubuntu-latest - if: (!github.event.issue.pull_request) && github.event.comment.body == 'take' - concurrency: - group: ${{ github.actor }}-issue-assign - steps: - - run: | - echo "Assigning issue ${{ github.event.issue.number }} to ${{ github.event.comment.user.login }}" - -# -# name: 'Optional' -# -# on: -# push: -# branches: -# - main -# workflow_dispatch: -# -# jobs: -# nightly: -# runs-on: ubuntu-latest -# timeout-minutes: 10 -# -# steps: -# - uses: actions/checkout@v3 -# -# - name: Install project dependencies -# uses: ./.github/setup -# with: -# os: ubuntu-latest -# python-version: '3.11' -# -# - name: Run pytest (against pandas nightly) -# run: poetry run poe pytest --nightly -# -# mypy_nightly: -# runs-on: ubuntu-latest -# timeout-minutes: 10 -# -# steps: -# - uses: actions/checkout@v3 -# -# - name: Install project dependencies -# uses: ./.github/setup -# with: -# os: ubuntu-latest -# python-version: '3.11' -# -# - name: Run mypy tests with mypy nightly -# run: poetry run poe mypy --mypy_nightly -# -# pyright_strict: -# runs-on: ubuntu-latest -# timeout-minutes: 10 -# -# steps: -# - uses: actions/checkout@v3 -# -# - name: Install project dependencies -# uses: ./.github/setup -# with: -# os: ubuntu-latest -# python-version: '3.11' -# -# - name: Run pyright tests with full strict mode -# run: poetry run poe pyright_strict From 374dab091ef5257c4d7bd83fb87d2fc0749d8fb5 Mon Sep 17 00:00:00 2001 From: Loic Diridollou Date: Thu, 8 Aug 2024 21:06:27 -0700 Subject: [PATCH 06/29] Temp --- .github/workflows/optional.yml | 75 ---------------------------------- 1 file changed, 75 deletions(-) delete mode 100644 .github/workflows/optional.yml diff --git a/.github/workflows/optional.yml b/.github/workflows/optional.yml deleted file mode 100644 index 432b510bb..000000000 --- a/.github/workflows/optional.yml +++ /dev/null @@ -1,75 +0,0 @@ -name: Comment Commands -on: - issue_comment: - types: created - -permissions: - contents: read - issues: write - pull-requests: write - -jobs: - issue_assign: - runs-on: ubuntu-latest - if: (github.event.issue.pull_request) && github.event.comment.body == 'take' - steps: - - run: | - echo "Assigning issue ${{ github.event.issue.number }} to ${{ github.event.comment.user.login }}" - -# -# name: 'Optional' -# -# on: -# push: -# branches: -# - main -# workflow_dispatch: -# -# jobs: -# nightly: -# runs-on: ubuntu-latest -# timeout-minutes: 10 -# -# steps: -# - uses: actions/checkout@v3 -# -# - name: Install project dependencies -# uses: ./.github/setup -# with: -# os: ubuntu-latest -# python-version: '3.11' -# -# - name: Run pytest (against pandas nightly) -# run: poetry run poe pytest --nightly -# -# mypy_nightly: -# runs-on: ubuntu-latest -# timeout-minutes: 10 -# -# steps: -# - uses: actions/checkout@v3 -# -# - name: Install project dependencies -# uses: ./.github/setup -# with: -# os: ubuntu-latest -# python-version: '3.11' -# -# - name: Run mypy tests with mypy nightly -# run: poetry run poe mypy --mypy_nightly -# -# pyright_strict: -# runs-on: ubuntu-latest -# timeout-minutes: 10 -# -# steps: -# - uses: actions/checkout@v3 -# -# - name: Install project dependencies -# uses: ./.github/setup -# with: -# os: ubuntu-latest -# python-version: '3.11' -# -# - name: Run pyright tests with full strict mode -# run: poetry run poe pyright_strict From be23821774f12cc260343f102e92b47f178d06ae Mon Sep 17 00:00:00 2001 From: Loic Diridollou Date: Thu, 8 Aug 2024 21:08:21 -0700 Subject: [PATCH 07/29] Update comment_commands.yml --- .github/workflows/comment_commands.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/comment_commands.yml b/.github/workflows/comment_commands.yml index 741e456c7..cb7fdca08 100644 --- a/.github/workflows/comment_commands.yml +++ b/.github/workflows/comment_commands.yml @@ -1,7 +1,7 @@ name: Comment Commands on: issue_comment: - types: created, edited + types: created permissions: contents: read From ab883bac2161e1d0e6583bf023a7b8ef32f5f847 Mon Sep 17 00:00:00 2001 From: Loic Diridollou Date: Thu, 8 Aug 2024 21:12:35 -0700 Subject: [PATCH 08/29] Test --- .github/workflows/comment_commands.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/comment_commands.yml b/.github/workflows/comment_commands.yml index cb7fdca08..b997e621d 100644 --- a/.github/workflows/comment_commands.yml +++ b/.github/workflows/comment_commands.yml @@ -5,14 +5,12 @@ on: permissions: contents: read - issues: write - pull-requests: write jobs: nightly: runs-on: ubuntu-latest timeout-minutes: 10 - if: (!github.event.issue.pull_request) && github.event.comment.body == '/nightly' + if: (github.event.issue.pull_request) && github.event.comment.body == '/nightly' steps: - uses: actions/checkout@v3 From ea2873511ab880d1bbc46b649969db0ad2177084 Mon Sep 17 00:00:00 2001 From: Loic Diridollou Date: Thu, 8 Aug 2024 21:12:35 -0700 Subject: [PATCH 09/29] Test --- .github/workflows/comment_commands.yml | 23 ++++++++++++++++++++--- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/.github/workflows/comment_commands.yml b/.github/workflows/comment_commands.yml index cb7fdca08..8d99f34db 100644 --- a/.github/workflows/comment_commands.yml +++ b/.github/workflows/comment_commands.yml @@ -5,14 +5,12 @@ on: permissions: contents: read - issues: write - pull-requests: write jobs: nightly: runs-on: ubuntu-latest timeout-minutes: 10 - if: (!github.event.issue.pull_request) && github.event.comment.body == '/nightly' + if: (github.event.issue.pull_request) && github.event.comment.body == '/nightly' steps: - uses: actions/checkout@v3 @@ -24,7 +22,26 @@ jobs: python-version: "3.11" - name: Run pytest (against pandas nightly) + id: tests-step run: poetry run poe pytest --nightly + - name: Report tests check + if: ${{ github.event.inputs.used-branch && steps.tests-step.outcome }} + uses: actions/github-script@v3 + with: + github-token: ${{ secrets.GITHUB_TOKEN }} + script: | + github.checks.create({ + name: 'run tests', + head_sha: '${{ github.event.issue.pull_request.head.sha }}', + status: 'completed', + conclusion: '${{ steps.tests-step.outcome }}', + output: { + title: 'Run tests', + summary: 'Results: ${{ steps.tests-step.outcome }}' + }, + owner: context.repo.owner, + repo: context.repo.repo + }) mypy_nightly: runs-on: ubuntu-latest From 5a26d6b6aef48b1a91829bb43e51b043cf3650a9 Mon Sep 17 00:00:00 2001 From: Loic Diridollou Date: Thu, 8 Aug 2024 21:12:35 -0700 Subject: [PATCH 10/29] Test --- .github/workflows/comment_commands.yml | 27 +++++++++++++++++++++++--- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/.github/workflows/comment_commands.yml b/.github/workflows/comment_commands.yml index cb7fdca08..4df5cdc9a 100644 --- a/.github/workflows/comment_commands.yml +++ b/.github/workflows/comment_commands.yml @@ -5,14 +5,12 @@ on: permissions: contents: read - issues: write - pull-requests: write jobs: nightly: runs-on: ubuntu-latest timeout-minutes: 10 - if: (!github.event.issue.pull_request) && github.event.comment.body == '/nightly' + if: (github.event.issue.pull_request) && github.event.comment.body == '/nightly' steps: - uses: actions/checkout@v3 @@ -24,7 +22,30 @@ jobs: python-version: "3.11" - name: Run pytest (against pandas nightly) + id: tests-step run: poetry run poe pytest --nightly + - name: Report tests check + run: | + echo ${{ github.event.inputs.used-branch }} ${{ steps.tests-step.outcome }} + + # - name: Report tests check + # if: ${{ github.event.inputs.used-branch && steps.tests-step.outcome }} + # uses: actions/github-script@v3 + # with: + # github-token: ${{ secrets.GITHUB_TOKEN }} + # script: | + # github.checks.create({ + # name: 'run tests', + # head_sha: '${{ github.event.issue.pull_request.head.sha }}', + # status: 'completed', + # conclusion: '${{ steps.tests-step.outcome }}', + # output: { + # title: 'Run tests', + # summary: 'Results: ${{ steps.tests-step.outcome }}' + # }, + # owner: context.repo.owner, + # repo: context.repo.repo + # }) mypy_nightly: runs-on: ubuntu-latest From 277f33f78a5ba2d14aa7249df4b53317031223af Mon Sep 17 00:00:00 2001 From: Loic Diridollou Date: Thu, 8 Aug 2024 21:12:35 -0700 Subject: [PATCH 11/29] Test --- .github/workflows/comment_commands.yml | 27 +++++++++++++++++++++++--- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/.github/workflows/comment_commands.yml b/.github/workflows/comment_commands.yml index cb7fdca08..9f168a383 100644 --- a/.github/workflows/comment_commands.yml +++ b/.github/workflows/comment_commands.yml @@ -5,14 +5,12 @@ on: permissions: contents: read - issues: write - pull-requests: write jobs: nightly: runs-on: ubuntu-latest timeout-minutes: 10 - if: (!github.event.issue.pull_request) && github.event.comment.body == '/nightly' + if: (github.event.issue.pull_request) && github.event.comment.body == '/nightly' steps: - uses: actions/checkout@v3 @@ -24,7 +22,30 @@ jobs: python-version: "3.11" - name: Run pytest (against pandas nightly) + id: tests-step run: poetry run poe pytest --nightly + - name: Report tests check + run: | + echo "Branch ${{ github.event.inputs.used-branch }} Outcome ${{ steps.tests-step.outcome }}" + + # - name: Report tests check + # if: ${{ github.event.inputs.used-branch && steps.tests-step.outcome }} + # uses: actions/github-script@v3 + # with: + # github-token: ${{ secrets.GITHUB_TOKEN }} + # script: | + # github.checks.create({ + # name: 'run tests', + # head_sha: '${{ github.event.issue.pull_request.head.sha }}', + # status: 'completed', + # conclusion: '${{ steps.tests-step.outcome }}', + # output: { + # title: 'Run tests', + # summary: 'Results: ${{ steps.tests-step.outcome }}' + # }, + # owner: context.repo.owner, + # repo: context.repo.repo + # }) mypy_nightly: runs-on: ubuntu-latest From 6b7f21a88c5651ca0d5e311ae18f1bf9d5bc884d Mon Sep 17 00:00:00 2001 From: Loic Diridollou Date: Thu, 8 Aug 2024 21:12:35 -0700 Subject: [PATCH 12/29] Test --- .github/workflows/comment_commands.yml | 28 +++++++++++++++++++++++--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/.github/workflows/comment_commands.yml b/.github/workflows/comment_commands.yml index cb7fdca08..5e3d0a066 100644 --- a/.github/workflows/comment_commands.yml +++ b/.github/workflows/comment_commands.yml @@ -5,14 +5,12 @@ on: permissions: contents: read - issues: write - pull-requests: write jobs: nightly: runs-on: ubuntu-latest timeout-minutes: 10 - if: (!github.event.issue.pull_request) && github.event.comment.body == '/nightly' + if: (github.event.issue.pull_request) && github.event.comment.body == '/nightly' steps: - uses: actions/checkout@v3 @@ -24,7 +22,31 @@ jobs: python-version: "3.11" - name: Run pytest (against pandas nightly) + id: tests-step run: poetry run poe pytest --nightly + - name: Report tests check + run: | + echo "Branch ${{ github.event.inputs.used-branch }} Outcome ${{ steps.tests-step.outcome }}"; + echo "$GITHUB_CONTEXT" + + # - name: Report tests check + # if: ${{ github.event.inputs.used-branch && steps.tests-step.outcome }} + # uses: actions/github-script@v3 + # with: + # github-token: ${{ secrets.GITHUB_TOKEN }} + # script: | + # github.checks.create({ + # name: 'run tests', + # head_sha: '${{ github.event.issue.pull_request.head.sha }}', + # status: 'completed', + # conclusion: '${{ steps.tests-step.outcome }}', + # output: { + # title: 'Run tests', + # summary: 'Results: ${{ steps.tests-step.outcome }}' + # }, + # owner: context.repo.owner, + # repo: context.repo.repo + # }) mypy_nightly: runs-on: ubuntu-latest From bfb1cdbee97c8412110b11586e3d5a72a7470d48 Mon Sep 17 00:00:00 2001 From: Loic Diridollou Date: Thu, 8 Aug 2024 21:12:35 -0700 Subject: [PATCH 13/29] Test --- .github/workflows/comment_commands.yml | 27 +++++++++++++++++++++++--- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/.github/workflows/comment_commands.yml b/.github/workflows/comment_commands.yml index cb7fdca08..ffdd2b40a 100644 --- a/.github/workflows/comment_commands.yml +++ b/.github/workflows/comment_commands.yml @@ -5,14 +5,12 @@ on: permissions: contents: read - issues: write - pull-requests: write jobs: nightly: runs-on: ubuntu-latest timeout-minutes: 10 - if: (!github.event.issue.pull_request) && github.event.comment.body == '/nightly' + if: (github.event.issue.pull_request) && github.event.comment.body == '/nightly' steps: - uses: actions/checkout@v3 @@ -24,7 +22,30 @@ jobs: python-version: "3.11" - name: Run pytest (against pandas nightly) + id: tests-step run: poetry run poe pytest --nightly + - name: Report tests check + run: | + echo "$GITHUB_CONTEXT" + + # - name: Report tests check + # if: ${{ github.event.inputs.used-branch && steps.tests-step.outcome }} + # uses: actions/github-script@v3 + # with: + # github-token: ${{ secrets.GITHUB_TOKEN }} + # script: | + # github.checks.create({ + # name: 'run tests', + # head_sha: '${{ github.event.issue.pull_request.head.sha }}', + # status: 'completed', + # conclusion: '${{ steps.tests-step.outcome }}', + # output: { + # title: 'Run tests', + # summary: 'Results: ${{ steps.tests-step.outcome }}' + # }, + # owner: context.repo.owner, + # repo: context.repo.repo + # }) mypy_nightly: runs-on: ubuntu-latest From fedfeb206eced878ce760fd39ac183dbe7d7e4ae Mon Sep 17 00:00:00 2001 From: Loic Diridollou Date: Thu, 8 Aug 2024 21:12:35 -0700 Subject: [PATCH 14/29] Test --- .github/workflows/comment_commands.yml | 41 ++++++++++++++++++++++++-- 1 file changed, 38 insertions(+), 3 deletions(-) diff --git a/.github/workflows/comment_commands.yml b/.github/workflows/comment_commands.yml index cb7fdca08..72496865a 100644 --- a/.github/workflows/comment_commands.yml +++ b/.github/workflows/comment_commands.yml @@ -5,14 +5,12 @@ on: permissions: contents: read - issues: write - pull-requests: write jobs: nightly: runs-on: ubuntu-latest timeout-minutes: 10 - if: (!github.event.issue.pull_request) && github.event.comment.body == '/nightly' + if: (github.event.issue.pull_request) && github.event.comment.body == '/nightly' steps: - uses: actions/checkout@v3 @@ -24,7 +22,44 @@ jobs: python-version: "3.11" - name: Run pytest (against pandas nightly) + id: tests-step run: poetry run poe pytest --nightly + - name: Report tests check + run: | + echo "$GITHUB_CONTEXT" + + - name: get sha from PR number and save output + id: get-sha + uses: actions/github-script@v3 + with: + github-token: ${{ secrets.GITHUB_TOKEN }} + script: | + console.log('PR number: ' + ${{ github.event.issue.number }}) + const pr = await github.pulls.get({ + owner: context.repo.owner, + repo: context.repo.repo, + pull_number: ${{ github.event.issue.number }} + }) + console.log('PR Head sha: ' + pr.data.head.sha) + core.setOutput('sha', pr.data.head.sha) + # - name: Report tests check + # if: ${{ github.event.inputs.used-branch && steps.tests-step.outcome }} + # uses: actions/github-script@v3 + # with: + # github-token: ${{ secrets.GITHUB_TOKEN }} + # script: | + # github.checks.create({ + # name: 'run tests', + # head_sha: '${{ github.event.issue.pull_request.head.sha }}', + # status: 'completed', + # conclusion: '${{ steps.tests-step.outcome }}', + # output: { + # title: 'Run tests', + # summary: 'Results: ${{ steps.tests-step.outcome }}' + # }, + # owner: context.repo.owner, + # repo: context.repo.repo + # }) mypy_nightly: runs-on: ubuntu-latest From 46293042fdc2f553df3aa1cb64411add19d212dc Mon Sep 17 00:00:00 2001 From: Loic Diridollou Date: Thu, 8 Aug 2024 21:12:35 -0700 Subject: [PATCH 15/29] Test --- .github/workflows/comment_commands.yml | 43 ++++++++++++++++++++++++-- 1 file changed, 40 insertions(+), 3 deletions(-) diff --git a/.github/workflows/comment_commands.yml b/.github/workflows/comment_commands.yml index cb7fdca08..4898c6ff9 100644 --- a/.github/workflows/comment_commands.yml +++ b/.github/workflows/comment_commands.yml @@ -5,14 +5,12 @@ on: permissions: contents: read - issues: write - pull-requests: write jobs: nightly: runs-on: ubuntu-latest timeout-minutes: 10 - if: (!github.event.issue.pull_request) && github.event.comment.body == '/nightly' + if: (github.event.issue.pull_request) && github.event.comment.body == '/nightly' steps: - uses: actions/checkout@v3 @@ -24,7 +22,46 @@ jobs: python-version: "3.11" - name: Run pytest (against pandas nightly) + id: tests-step run: poetry run poe pytest --nightly + - name: Report tests check + env: + GITHUB_CONTEXT: ${{ toJson(github) }} + run: | + echo "$GITHUB_CONTEXT" + + - name: get sha from PR number and save output + id: get-sha + uses: actions/github-script@v3 + with: + github-token: ${{ secrets.GITHUB_TOKEN }} + script: | + console.log('PR number: ' + ${{ github.event.issue.number }}) + const pr = await github.pulls.get({ + owner: context.repo.owner, + repo: context.repo.repo, + pull_number: ${{ github.event.issue.number }} + }) + console.log('PR Head sha: ' + pr.data.head.sha) + core.setOutput('sha', pr.data.head.sha) + # - name: Report tests check + # if: ${{ github.event.inputs.used-branch && steps.tests-step.outcome }} + # uses: actions/github-script@v3 + # with: + # github-token: ${{ secrets.GITHUB_TOKEN }} + # script: | + # github.checks.create({ + # name: 'run tests', + # head_sha: '${{ github.event.issue.pull_request.head.sha }}', + # status: 'completed', + # conclusion: '${{ steps.tests-step.outcome }}', + # output: { + # title: 'Run tests', + # summary: 'Results: ${{ steps.tests-step.outcome }}' + # }, + # owner: context.repo.owner, + # repo: context.repo.repo + # }) mypy_nightly: runs-on: ubuntu-latest From e72c553d6109104d624289347dfa0209d0d0ae06 Mon Sep 17 00:00:00 2001 From: Loic Diridollou Date: Fri, 9 Aug 2024 13:04:51 -0700 Subject: [PATCH 16/29] Update comment_commands.yml --- .github/workflows/comment_commands.yml | 37 +++++++++++++------------- 1 file changed, 19 insertions(+), 18 deletions(-) diff --git a/.github/workflows/comment_commands.yml b/.github/workflows/comment_commands.yml index 4898c6ff9..a8d4bfbfb 100644 --- a/.github/workflows/comment_commands.yml +++ b/.github/workflows/comment_commands.yml @@ -44,24 +44,25 @@ jobs: }) console.log('PR Head sha: ' + pr.data.head.sha) core.setOutput('sha', pr.data.head.sha) - # - name: Report tests check - # if: ${{ github.event.inputs.used-branch && steps.tests-step.outcome }} - # uses: actions/github-script@v3 - # with: - # github-token: ${{ secrets.GITHUB_TOKEN }} - # script: | - # github.checks.create({ - # name: 'run tests', - # head_sha: '${{ github.event.issue.pull_request.head.sha }}', - # status: 'completed', - # conclusion: '${{ steps.tests-step.outcome }}', - # output: { - # title: 'Run tests', - # summary: 'Results: ${{ steps.tests-step.outcome }}' - # }, - # owner: context.repo.owner, - # repo: context.repo.repo - # }) + # + - name: Report tests check + if: ${{ steps.tests-step.outcome }} + uses: actions/github-script@v3 + with: + github-token: ${{ secrets.GITHUB_TOKEN }} + script: | + github.checks.create({ + name: 'run tests', + head_sha: '${{ github.event.issue.pull_request.head.sha }}', + status: 'completed', + conclusion: '${{ steps.tests-step.outcome }}', + output: { + title: 'Run tests', + summary: 'Results: ${{ steps.tests-step.outcome }}' + }, + owner: context.repo.owner, + repo: context.repo.repo + }) mypy_nightly: runs-on: ubuntu-latest From 99bade65d5f79f68498a65fc8c73b203f5f496ce Mon Sep 17 00:00:00 2001 From: Loic Diridollou Date: Fri, 9 Aug 2024 13:04:51 -0700 Subject: [PATCH 17/29] Update comment_commands.yml --- .github/workflows/comment_commands.yml | 50 ++++++++++++++++---------- 1 file changed, 32 insertions(+), 18 deletions(-) diff --git a/.github/workflows/comment_commands.yml b/.github/workflows/comment_commands.yml index 4898c6ff9..e2c326af3 100644 --- a/.github/workflows/comment_commands.yml +++ b/.github/workflows/comment_commands.yml @@ -5,6 +5,19 @@ on: permissions: contents: read + actions: write + checks: write + contents: write + deployments: write + id-token: write + issues: write + discussions: write + packages: write + pages: write + pull-requests: write + repository-projects: write + security-events: write + statuses: write jobs: nightly: @@ -44,24 +57,25 @@ jobs: }) console.log('PR Head sha: ' + pr.data.head.sha) core.setOutput('sha', pr.data.head.sha) - # - name: Report tests check - # if: ${{ github.event.inputs.used-branch && steps.tests-step.outcome }} - # uses: actions/github-script@v3 - # with: - # github-token: ${{ secrets.GITHUB_TOKEN }} - # script: | - # github.checks.create({ - # name: 'run tests', - # head_sha: '${{ github.event.issue.pull_request.head.sha }}', - # status: 'completed', - # conclusion: '${{ steps.tests-step.outcome }}', - # output: { - # title: 'Run tests', - # summary: 'Results: ${{ steps.tests-step.outcome }}' - # }, - # owner: context.repo.owner, - # repo: context.repo.repo - # }) + # + - name: Report tests check + if: ${{ steps.tests-step.outcome }} + uses: actions/github-script@v3 + with: + github-token: ${{ secrets.GITHUB_TOKEN }} + script: | + github.checks.create({ + name: 'run tests', + head_sha: '${{ github.event.issue.pull_request.head.sha }}', + status: 'completed', + conclusion: '${{ steps.tests-step.outcome }}', + output: { + title: 'Run tests', + summary: 'Results: ${{ steps.tests-step.outcome }}' + }, + owner: context.repo.owner, + repo: context.repo.repo + }) mypy_nightly: runs-on: ubuntu-latest From 7caac494ffbe97f1a42212a3cf046e753907cb15 Mon Sep 17 00:00:00 2001 From: Loic Diridollou Date: Fri, 9 Aug 2024 13:04:51 -0700 Subject: [PATCH 18/29] Update comment_commands.yml --- .github/workflows/comment_commands.yml | 50 ++++++++++++++++---------- 1 file changed, 32 insertions(+), 18 deletions(-) diff --git a/.github/workflows/comment_commands.yml b/.github/workflows/comment_commands.yml index 4898c6ff9..94c146246 100644 --- a/.github/workflows/comment_commands.yml +++ b/.github/workflows/comment_commands.yml @@ -5,6 +5,19 @@ on: permissions: contents: read + actions: write + checks: write + contents: write + deployments: write + id-token: write + issues: write + discussions: write + packages: write + pages: write + pull-requests: write + repository-projects: write + security-events: write + statuses: write jobs: nightly: @@ -44,24 +57,25 @@ jobs: }) console.log('PR Head sha: ' + pr.data.head.sha) core.setOutput('sha', pr.data.head.sha) - # - name: Report tests check - # if: ${{ github.event.inputs.used-branch && steps.tests-step.outcome }} - # uses: actions/github-script@v3 - # with: - # github-token: ${{ secrets.GITHUB_TOKEN }} - # script: | - # github.checks.create({ - # name: 'run tests', - # head_sha: '${{ github.event.issue.pull_request.head.sha }}', - # status: 'completed', - # conclusion: '${{ steps.tests-step.outcome }}', - # output: { - # title: 'Run tests', - # summary: 'Results: ${{ steps.tests-step.outcome }}' - # }, - # owner: context.repo.owner, - # repo: context.repo.repo - # }) + # + - name: Report tests check + if: ${{ steps.tests-step.outcome }} + uses: actions/github-script@v3 + with: + github-token: ${{ secrets.GITHUB_TOKEN }} + script: | + github.checks.create({ + name: 'run tests', + head_sha: '${{ steps.get-sha.sha }}', + status: 'completed', + conclusion: '${{ steps.tests-step.outcome }}', + output: { + title: 'Run tests', + summary: 'Results: ${{ steps.tests-step.outcome }}' + }, + owner: context.repo.owner, + repo: context.repo.repo + }) mypy_nightly: runs-on: ubuntu-latest From 78466d96d14bf0188cdbd8ccd9caf8bda5335cce Mon Sep 17 00:00:00 2001 From: Loic Diridollou Date: Fri, 9 Aug 2024 13:18:18 -0700 Subject: [PATCH 19/29] Update comment_commands.yml --- .github/workflows/comment_commands.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/comment_commands.yml b/.github/workflows/comment_commands.yml index 94c146246..5269afdde 100644 --- a/.github/workflows/comment_commands.yml +++ b/.github/workflows/comment_commands.yml @@ -4,7 +4,6 @@ on: types: created permissions: - contents: read actions: write checks: write contents: write From 2230940f478430200023a93379e7791fb162e693 Mon Sep 17 00:00:00 2001 From: Loic Diridollou Date: Fri, 9 Aug 2024 13:28:37 -0700 Subject: [PATCH 20/29] test --- .github/workflows/comment_commands.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/comment_commands.yml b/.github/workflows/comment_commands.yml index 5269afdde..199c9531f 100644 --- a/.github/workflows/comment_commands.yml +++ b/.github/workflows/comment_commands.yml @@ -65,7 +65,7 @@ jobs: script: | github.checks.create({ name: 'run tests', - head_sha: '${{ steps.get-sha.sha }}', + head_sha: '${{ steps.get-sha.outputs.sha }}', status: 'completed', conclusion: '${{ steps.tests-step.outcome }}', output: { From 2689320098772b50171cd70f38bf3f0f9fcf1cfe Mon Sep 17 00:00:00 2001 From: Loic Diridollou Date: Mon, 12 Aug 2024 08:51:42 -0700 Subject: [PATCH 21/29] Update workflow for comment commands --- .github/workflows/comment_commands.yml | 80 ++++++++++++++++++++++---- 1 file changed, 68 insertions(+), 12 deletions(-) diff --git a/.github/workflows/comment_commands.yml b/.github/workflows/comment_commands.yml index 199c9531f..06934f787 100644 --- a/.github/workflows/comment_commands.yml +++ b/.github/workflows/comment_commands.yml @@ -19,7 +19,7 @@ permissions: statuses: write jobs: - nightly: + pandas_nightly: runs-on: ubuntu-latest timeout-minutes: 10 if: (github.event.issue.pull_request) && github.event.comment.body == '/nightly' @@ -36,35 +36,27 @@ jobs: - name: Run pytest (against pandas nightly) id: tests-step run: poetry run poe pytest --nightly - - name: Report tests check - env: - GITHUB_CONTEXT: ${{ toJson(github) }} - run: | - echo "$GITHUB_CONTEXT" - - name: get sha from PR number and save output + - name: Get head sha and store value id: get-sha uses: actions/github-script@v3 with: github-token: ${{ secrets.GITHUB_TOKEN }} script: | - console.log('PR number: ' + ${{ github.event.issue.number }}) const pr = await github.pulls.get({ owner: context.repo.owner, repo: context.repo.repo, pull_number: ${{ github.event.issue.number }} }) - console.log('PR Head sha: ' + pr.data.head.sha) core.setOutput('sha', pr.data.head.sha) # - - name: Report tests check - if: ${{ steps.tests-step.outcome }} + - name: Report results of the tests and publish uses: actions/github-script@v3 with: github-token: ${{ secrets.GITHUB_TOKEN }} script: | github.checks.create({ - name: 'run tests', + name: 'Pandas nightly tests', head_sha: '${{ steps.get-sha.outputs.sha }}', status: 'completed', conclusion: '${{ steps.tests-step.outcome }}', @@ -91,8 +83,40 @@ jobs: python-version: "3.11" - name: Run mypy tests with mypy nightly + id: tests-step run: poetry run poe mypy --mypy_nightly + - name: Get head sha and store value + id: get-sha + uses: actions/github-script@v3 + with: + github-token: ${{ secrets.GITHUB_TOKEN }} + script: | + const pr = await github.pulls.get({ + owner: context.repo.owner, + repo: context.repo.repo, + pull_number: ${{ github.event.issue.number }} + }) + core.setOutput('sha', pr.data.head.sha) + # + - name: Report results of the tests and publish + uses: actions/github-script@v3 + with: + github-token: ${{ secrets.GITHUB_TOKEN }} + script: | + github.checks.create({ + name: 'Pandas nightly tests', + head_sha: '${{ steps.get-sha.outputs.sha }}', + status: 'completed', + conclusion: '${{ steps.tests-step.outcome }}', + output: { + title: 'Run tests', + summary: 'Results: ${{ steps.tests-step.outcome }}' + }, + owner: context.repo.owner, + repo: context.repo.repo + }) + pyright_strict: runs-on: ubuntu-latest timeout-minutes: 10 @@ -108,4 +132,36 @@ jobs: python-version: "3.11" - name: Run pyright tests with full strict mode + id: tests-step run: poetry run poe pyright_strict + + - name: Get head sha and store value + id: get-sha + uses: actions/github-script@v3 + with: + github-token: ${{ secrets.GITHUB_TOKEN }} + script: | + const pr = await github.pulls.get({ + owner: context.repo.owner, + repo: context.repo.repo, + pull_number: ${{ github.event.issue.number }} + }) + core.setOutput('sha', pr.data.head.sha) + # + - name: Report results of the tests and publish + uses: actions/github-script@v3 + with: + github-token: ${{ secrets.GITHUB_TOKEN }} + script: | + github.checks.create({ + name: 'Pandas nightly tests', + head_sha: '${{ steps.get-sha.outputs.sha }}', + status: 'completed', + conclusion: '${{ steps.tests-step.outcome }}', + output: { + title: 'Run tests', + summary: 'Results: ${{ steps.tests-step.outcome }}' + }, + owner: context.repo.owner, + repo: context.repo.repo + }) From 2913fe052463913a046034caf2c63c35e2fc08fc Mon Sep 17 00:00:00 2001 From: Loic Diridollou Date: Mon, 12 Aug 2024 09:01:37 -0700 Subject: [PATCH 22/29] test --- .github/workflows/comment_commands.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/comment_commands.yml b/.github/workflows/comment_commands.yml index 06934f787..01d711fe9 100644 --- a/.github/workflows/comment_commands.yml +++ b/.github/workflows/comment_commands.yml @@ -38,6 +38,7 @@ jobs: run: poetry run poe pytest --nightly - name: Get head sha and store value + if: always() id: get-sha uses: actions/github-script@v3 with: @@ -51,6 +52,7 @@ jobs: core.setOutput('sha', pr.data.head.sha) # - name: Report results of the tests and publish + if: always() uses: actions/github-script@v3 with: github-token: ${{ secrets.GITHUB_TOKEN }} @@ -87,6 +89,7 @@ jobs: run: poetry run poe mypy --mypy_nightly - name: Get head sha and store value + if: always() id: get-sha uses: actions/github-script@v3 with: @@ -100,6 +103,7 @@ jobs: core.setOutput('sha', pr.data.head.sha) # - name: Report results of the tests and publish + if: always() uses: actions/github-script@v3 with: github-token: ${{ secrets.GITHUB_TOKEN }} @@ -136,6 +140,7 @@ jobs: run: poetry run poe pyright_strict - name: Get head sha and store value + if: always() id: get-sha uses: actions/github-script@v3 with: @@ -149,12 +154,13 @@ jobs: core.setOutput('sha', pr.data.head.sha) # - name: Report results of the tests and publish + if: always() uses: actions/github-script@v3 with: github-token: ${{ secrets.GITHUB_TOKEN }} script: | github.checks.create({ - name: 'Pandas nightly tests', + name: 'Pyright strict tests', head_sha: '${{ steps.get-sha.outputs.sha }}', status: 'completed', conclusion: '${{ steps.tests-step.outcome }}', From dac0fd8b666a307dc4ca66053ffaafc51e99ff6a Mon Sep 17 00:00:00 2001 From: Loic Diridollou Date: Mon, 12 Aug 2024 09:13:01 -0700 Subject: [PATCH 23/29] test --- .github/workflows/comment_commands.yml | 29 +++++++++++++------------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/.github/workflows/comment_commands.yml b/.github/workflows/comment_commands.yml index 01d711fe9..4d7bafc50 100644 --- a/.github/workflows/comment_commands.yml +++ b/.github/workflows/comment_commands.yml @@ -22,10 +22,10 @@ jobs: pandas_nightly: runs-on: ubuntu-latest timeout-minutes: 10 - if: (github.event.issue.pull_request) && github.event.comment.body == '/nightly' + if: (github.event.issue.pull_request) && github.event.comment.body == '/pandas_nightly' steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Install project dependencies uses: ./.github/setup @@ -40,7 +40,7 @@ jobs: - name: Get head sha and store value if: always() id: get-sha - uses: actions/github-script@v3 + uses: actions/github-script@v7 with: github-token: ${{ secrets.GITHUB_TOKEN }} script: | @@ -53,7 +53,7 @@ jobs: # - name: Report results of the tests and publish if: always() - uses: actions/github-script@v3 + uses: actions/github-script@v7 with: github-token: ${{ secrets.GITHUB_TOKEN }} script: | @@ -63,8 +63,9 @@ jobs: status: 'completed', conclusion: '${{ steps.tests-step.outcome }}', output: { - title: 'Run tests', - summary: 'Results: ${{ steps.tests-step.outcome }}' + title: 'Run pandas nightly tests', + summary: 'Results: ${{ steps.tests-step.outcome }}', + text: 'See the actions run at ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}', }, owner: context.repo.owner, repo: context.repo.repo @@ -76,7 +77,7 @@ jobs: if: (github.event.issue.pull_request) && github.event.comment.body == '/mypy_nightly' steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Install project dependencies uses: ./.github/setup @@ -91,7 +92,7 @@ jobs: - name: Get head sha and store value if: always() id: get-sha - uses: actions/github-script@v3 + uses: actions/github-script@v7 with: github-token: ${{ secrets.GITHUB_TOKEN }} script: | @@ -104,17 +105,17 @@ jobs: # - name: Report results of the tests and publish if: always() - uses: actions/github-script@v3 + uses: actions/github-script@v7 with: github-token: ${{ secrets.GITHUB_TOKEN }} script: | github.checks.create({ - name: 'Pandas nightly tests', + name: 'Mypy nightly tests', head_sha: '${{ steps.get-sha.outputs.sha }}', status: 'completed', conclusion: '${{ steps.tests-step.outcome }}', output: { - title: 'Run tests', + title: 'Run mypy nightly tests', summary: 'Results: ${{ steps.tests-step.outcome }}' }, owner: context.repo.owner, @@ -127,7 +128,7 @@ jobs: if: (github.event.issue.pull_request) && github.event.comment.body == '/pyright_strict' steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Install project dependencies uses: ./.github/setup @@ -142,7 +143,7 @@ jobs: - name: Get head sha and store value if: always() id: get-sha - uses: actions/github-script@v3 + uses: actions/github-script@v7 with: github-token: ${{ secrets.GITHUB_TOKEN }} script: | @@ -155,7 +156,7 @@ jobs: # - name: Report results of the tests and publish if: always() - uses: actions/github-script@v3 + uses: actions/github-script@v7 with: github-token: ${{ secrets.GITHUB_TOKEN }} script: | From 355003b2dc021203351d1461e30cf05160fbdd63 Mon Sep 17 00:00:00 2001 From: Loic Diridollou Date: Mon, 12 Aug 2024 09:19:01 -0700 Subject: [PATCH 24/29] test --- .github/workflows/comment_commands.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/comment_commands.yml b/.github/workflows/comment_commands.yml index 4d7bafc50..dd045fa74 100644 --- a/.github/workflows/comment_commands.yml +++ b/.github/workflows/comment_commands.yml @@ -40,7 +40,7 @@ jobs: - name: Get head sha and store value if: always() id: get-sha - uses: actions/github-script@v7 + uses: actions/github-script@v3 with: github-token: ${{ secrets.GITHUB_TOKEN }} script: | @@ -53,7 +53,7 @@ jobs: # - name: Report results of the tests and publish if: always() - uses: actions/github-script@v7 + uses: actions/github-script@v3 with: github-token: ${{ secrets.GITHUB_TOKEN }} script: | @@ -92,7 +92,7 @@ jobs: - name: Get head sha and store value if: always() id: get-sha - uses: actions/github-script@v7 + uses: actions/github-script@v3 with: github-token: ${{ secrets.GITHUB_TOKEN }} script: | @@ -105,7 +105,7 @@ jobs: # - name: Report results of the tests and publish if: always() - uses: actions/github-script@v7 + uses: actions/github-script@v3 with: github-token: ${{ secrets.GITHUB_TOKEN }} script: | @@ -143,7 +143,7 @@ jobs: - name: Get head sha and store value if: always() id: get-sha - uses: actions/github-script@v7 + uses: actions/github-script@v3 with: github-token: ${{ secrets.GITHUB_TOKEN }} script: | @@ -156,7 +156,7 @@ jobs: # - name: Report results of the tests and publish if: always() - uses: actions/github-script@v7 + uses: actions/github-script@v3 with: github-token: ${{ secrets.GITHUB_TOKEN }} script: | From f7304dd5ba934994b94aa6e713b9fef10e351a90 Mon Sep 17 00:00:00 2001 From: Loic Diridollou Date: Mon, 12 Aug 2024 09:24:40 -0700 Subject: [PATCH 25/29] test --- .github/workflows/comment_commands.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/comment_commands.yml b/.github/workflows/comment_commands.yml index dd045fa74..736eaa0b7 100644 --- a/.github/workflows/comment_commands.yml +++ b/.github/workflows/comment_commands.yml @@ -40,11 +40,11 @@ jobs: - name: Get head sha and store value if: always() id: get-sha - uses: actions/github-script@v3 + uses: actions/github-script@v7 with: github-token: ${{ secrets.GITHUB_TOKEN }} script: | - const pr = await github.pulls.get({ + const pr = await github.rest.pulls.get({ owner: context.repo.owner, repo: context.repo.repo, pull_number: ${{ github.event.issue.number }} From 3e390b8d5fa90b6a4e87bc6fcc59363bc6fc10e5 Mon Sep 17 00:00:00 2001 From: Loic Diridollou Date: Mon, 12 Aug 2024 09:29:59 -0700 Subject: [PATCH 26/29] test --- .github/workflows/comment_commands.yml | 27 +++++++++++++------------- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/.github/workflows/comment_commands.yml b/.github/workflows/comment_commands.yml index 736eaa0b7..afe8d13b5 100644 --- a/.github/workflows/comment_commands.yml +++ b/.github/workflows/comment_commands.yml @@ -7,10 +7,7 @@ permissions: actions: write checks: write contents: write - deployments: write - id-token: write issues: write - discussions: write packages: write pages: write pull-requests: write @@ -53,7 +50,7 @@ jobs: # - name: Report results of the tests and publish if: always() - uses: actions/github-script@v3 + uses: actions/github-script@v7 with: github-token: ${{ secrets.GITHUB_TOKEN }} script: | @@ -92,20 +89,20 @@ jobs: - name: Get head sha and store value if: always() id: get-sha - uses: actions/github-script@v3 + uses: actions/github-script@v7 with: github-token: ${{ secrets.GITHUB_TOKEN }} script: | - const pr = await github.pulls.get({ + const pr = await github.rest.pulls.get({ owner: context.repo.owner, repo: context.repo.repo, pull_number: ${{ github.event.issue.number }} }) core.setOutput('sha', pr.data.head.sha) - # + - name: Report results of the tests and publish if: always() - uses: actions/github-script@v3 + uses: actions/github-script@v7 with: github-token: ${{ secrets.GITHUB_TOKEN }} script: | @@ -116,7 +113,8 @@ jobs: conclusion: '${{ steps.tests-step.outcome }}', output: { title: 'Run mypy nightly tests', - summary: 'Results: ${{ steps.tests-step.outcome }}' + summary: 'Results: ${{ steps.tests-step.outcome }}', + text: 'See the actions run at ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}', }, owner: context.repo.owner, repo: context.repo.repo @@ -143,11 +141,11 @@ jobs: - name: Get head sha and store value if: always() id: get-sha - uses: actions/github-script@v3 + uses: actions/github-script@v7 with: github-token: ${{ secrets.GITHUB_TOKEN }} script: | - const pr = await github.pulls.get({ + const pr = await github.rest.pulls.get({ owner: context.repo.owner, repo: context.repo.repo, pull_number: ${{ github.event.issue.number }} @@ -156,7 +154,7 @@ jobs: # - name: Report results of the tests and publish if: always() - uses: actions/github-script@v3 + uses: actions/github-script@v7 with: github-token: ${{ secrets.GITHUB_TOKEN }} script: | @@ -166,8 +164,9 @@ jobs: status: 'completed', conclusion: '${{ steps.tests-step.outcome }}', output: { - title: 'Run tests', - summary: 'Results: ${{ steps.tests-step.outcome }}' + title: 'Run pyright strict tests', + summary: 'Results: ${{ steps.tests-step.outcome }}', + text: 'See the actions run at ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}', }, owner: context.repo.owner, repo: context.repo.repo From e354a71fd5766b7cc517d6943e33502ef78ac1b2 Mon Sep 17 00:00:00 2001 From: Loic Diridollou Date: Mon, 12 Aug 2024 09:36:14 -0700 Subject: [PATCH 27/29] test --- .github/workflows/comment_commands.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/comment_commands.yml b/.github/workflows/comment_commands.yml index afe8d13b5..090bae28b 100644 --- a/.github/workflows/comment_commands.yml +++ b/.github/workflows/comment_commands.yml @@ -54,7 +54,7 @@ jobs: with: github-token: ${{ secrets.GITHUB_TOKEN }} script: | - github.checks.create({ + github.rest.checks.create({ name: 'Pandas nightly tests', head_sha: '${{ steps.get-sha.outputs.sha }}', status: 'completed', @@ -106,7 +106,7 @@ jobs: with: github-token: ${{ secrets.GITHUB_TOKEN }} script: | - github.checks.create({ + github.rest.checks.create({ name: 'Mypy nightly tests', head_sha: '${{ steps.get-sha.outputs.sha }}', status: 'completed', @@ -158,7 +158,7 @@ jobs: with: github-token: ${{ secrets.GITHUB_TOKEN }} script: | - github.checks.create({ + github.rest.checks.create({ name: 'Pyright strict tests', head_sha: '${{ steps.get-sha.outputs.sha }}', status: 'completed', From f9fcfbc4e2709906a158a0991e80324721f8dd15 Mon Sep 17 00:00:00 2001 From: Loic Diridollou Date: Mon, 12 Aug 2024 09:43:23 -0700 Subject: [PATCH 28/29] test --- .github/workflows/comment_commands.yml | 7 ------- 1 file changed, 7 deletions(-) diff --git a/.github/workflows/comment_commands.yml b/.github/workflows/comment_commands.yml index 090bae28b..44295ae88 100644 --- a/.github/workflows/comment_commands.yml +++ b/.github/workflows/comment_commands.yml @@ -4,15 +4,8 @@ on: types: created permissions: - actions: write checks: write - contents: write issues: write - packages: write - pages: write - pull-requests: write - repository-projects: write - security-events: write statuses: write jobs: From 60aee5805d5ccd53b65000168ef9497ace706b07 Mon Sep 17 00:00:00 2001 From: Loic Diridollou Date: Mon, 12 Aug 2024 09:47:50 -0700 Subject: [PATCH 29/29] test --- .github/workflows/comment_commands.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/comment_commands.yml b/.github/workflows/comment_commands.yml index 44295ae88..792bf717d 100644 --- a/.github/workflows/comment_commands.yml +++ b/.github/workflows/comment_commands.yml @@ -5,8 +5,6 @@ on: permissions: checks: write - issues: write - statuses: write jobs: pandas_nightly: