Provide a method that can handle messages #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenzodonini
requested changes
Jun 17, 2025
ocppj/server.go
Outdated
| @@ -41,7 +43,7 @@ type InvalidMessageHook func(client ws.Channel, err *ocpp.Error, rawJson string, | |||
| // s := ocppj.NewServer(ws.NewServer(), nil, nil) | |||
| // | |||
| // The dispatcher's associated ClientState will be set during initialization. | |||
| func NewServer(wsServer ws.Server, dispatcher ServerDispatcher, stateHandler ServerState, profiles ...*ocpp.Profile) *Server { | |||
| func NewServer(wsServer ws.Server, dispatcher ServerDispatcher, stateHandler ServerState, msgHooks MessageHooks, profiles ...*ocpp.Profile) *Server { | |||
There was a problem hiding this comment.
This is a breaking change and several custom implementations may be affected. I believe the added SetMessageHooks setter is good enough, so we don't have to also include it as a parameter in the constructor
example/1.6/cs/central_system_sim.go
Outdated
| @@ -231,6 +232,10 @@ func main() { | |||
| log.WithField("client", chargePoint.ID()).Info("charge point disconnected") | |||
| delete(handler.chargePoints, chargePoint.ID()) | |||
| }) | |||
| // set message hook | |||
| centralSystem.SetMessageHooks(func(direction, chargePointID, msgType string, payload []byte) { | |||
| fmt.Printf("direction：%s \n cpid：%s \n msgType: %s \n payload: %s\n", direction, chargePointID, msgType, string(payload)) | |||
There was a problem hiding this comment.
chore: this should invoke the logger instead of fmt.Printf
added 2 commits
June 26, 2025 09:43
2.It was modified to include it as a parameter in unnecessary constructors as well
xBlaz3kx
reviewed
Aug 17, 2025
| @@ -66,7 +66,7 @@ func NewServer(wsServer ws.Server, dispatcher ServerDispatcher, stateHandler Ser | |||
| for _, profile := range profiles { | |||
| s.AddProfile(profile) | |||
| } | |||
| s.MessageHooks = msgHooks | |||
| //s.MessageHooks = msgHooks | |||
There was a problem hiding this comment.
This can be removed entirely
xBlaz3kx
reviewed
Aug 17, 2025
|
|
||
| // SetMessageHooks sets the hooks for logging incoming and outgoing messages. | ||
| func (cs *centralSystem) SetMessageHooks(message func(direction, clientId, messageType string, payload []byte)) { | ||
| cs.server.SetMessageHooks(message) |
There was a problem hiding this comment.
Maybe a nil check would be nice to prevent crashing in case someone decides to pass in a nil function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Provide a message processing method. Databases or message forwarding, etc. can be used。
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.
Further comments
We want to record the messages of OCPP through a database such as mongodb. Or forward some instruction messages such as MeterValues and StatusNotification to the mobile terminal for display.