Skip to content

Feature/apollon2 migration #10923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from
Draft

Conversation

egenerse
Copy link

THIS IS THE MAIN BRANCH FOR APOLLON2 INTEGRATION FOR ARTEMIS

Checklist

General

Server

  • Important: I implemented the changes with a very good performance and prevented too many (unnecessary) and too complex database calls.
  • I strictly followed the principle of data economy for all database calls.
  • I strictly followed the server coding and design guidelines.
  • I added multiple integration tests (Spring) related to the features (with a high test coverage).
  • I added pre-authorization annotations according to the guidelines and checked the course groups for all new REST Calls (security).
  • I documented the Java code using JavaDoc style.

Client

  • Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data (e.g. using paging).
  • I strictly followed the principle of data economy for all client-server REST calls.
  • I strictly followed the client coding and design guidelines.
  • Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
  • I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
  • I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
  • I documented the TypeScript code using JSDoc style.
  • I added multiple screenshots/screencasts of my UI changes.
  • I translated all newly inserted strings into English and German.

Changes affecting Programming Exercises

  • High priority: I tested all changes and their related features with all corresponding user types on a test server configured with the integrated lifecycle setup (LocalVC and LocalCI).
  • I tested all changes and their related features with all corresponding user types on a test server configured with LocalVC and Jenkins.

Motivation and Context

Description

Steps for Testing

Prerequisites:

  • 1 Instructor
  • 2 Students
  • 1 Programming Exercise with Complaints enabled
  1. Log in to Artemis
  2. Navigate to Course Administration
  3. ...

Exam Mode Testing

Prerequisites:

  • 1 Instructor
  • 2 Students
  • 1 Exam with a Programming Exercise
  1. Log in to Artemis
  2. Participate in the exam as a student
  3. Make sure that the UI of the programming exercise in the exam mode stays unchanged. You can use the exam mode documentation as reference.
  4. ...

Testserver States

You can manage test servers using Helios. Check environment statuses in the environment list. To deploy to a test server, go to the CI/CD page, find your PR or branch, and trigger the deployment.

Review Progress

Performance Review

  • I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance even for very large courses with more than 2000 students.
  • I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance even for very large courses with more than 2000 students.

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Exam Mode Test

  • Test 1
  • Test 2

Performance Tests

  • Test 1
  • Test 2

Test Coverage

Screenshots

@github-project-automation github-project-automation bot moved this to Work In Progress in Artemis Development May 26, 2025
@github-actions github-actions bot added server Pull requests that update Java code. (Added Automatically!) client Pull requests that update TypeScript code. (Added Automatically!) assessment Pull requests that affect the corresponding module exam Pull requests that affect the corresponding module modeling Pull requests that affect the corresponding module quiz Pull requests that affect the corresponding module labels May 26, 2025
Copy link

End-to-End (E2E) Test Results Summary

Copy link

End-to-End (E2E) Test Results Summary

TestsPassed ☑️Skipped ⚠️Failed ❌️Time ⏱
End-to-End (E2E) Test Report201 ran176 passed10 skipped15 failed1h 37m 26s 657ms
TestResultTime ⏱
End-to-End (E2E) Test Report
e2e/exam/ExamTestRun.spec.ts
ts.Exam test run › Manage a test run › Conducts a test run❌ failure6m 6s 472ms
e2e/exercise/ExerciseImport.spec.ts
ts.Import exercises › Imports exercises › Imports modeling exercise❌ failure2m 7s 108ms
e2e/exercise/modeling/ModelingExerciseAssessment.spec.ts
ts.Modeling Exercise Assessment › Handling complaints › Tutor can assess a submission❌ failure17s 261ms
e2e/exercise/modeling/ModelingExerciseManagement.spec.ts
ts.Modeling Exercise Management › Create Modeling Exercise › Create a new modeling exercise❌ failure2m 4s 740ms
e2e/exercise/modeling/ModelingExerciseParticipation.spec.ts
ts.Modeling Exercise Participation › Student can start and submit their model❌ failure2m 3s 858ms
e2e/exercise/quiz-exercise/QuizExerciseDropLocation.spec.ts
ts.Quiz Exercise Drop Location Spec › DnD Quiz drop locations › Checks drop locations❌ failure2m 2s 984ms
e2e/Logout.spec.ts
ts.Logout tests › Logs out after confirmation of dialog for unsaved changes on exercise mode❌ failure2m 3s 71ms
ts.Logout tests › Stays logged in after dismissal of dialog for unsaved changes on exercise mode❌ failure2m 3s 126ms
e2e/exam/ExamAssessment.spec.ts
ts.Exam assessment › Modeling exercise assessment › Assess a modeling exercise submission❌ failure
e2e/exam/ExamParticipation.spec.ts
ts.Exam participation › Early Hand-in › Participates as a student in a registered exam❌ failure6m 8s 320ms
ts.Exam participation › Early Hand-in › Using navigation sidebar to navigate within exam❌ failure6m 6s 708ms
e2e/exam/ExamResults.spec.ts
ts.Exam Results › Check exam exercise results › Check exam results for modeling exercise › Check exam modeling exercise results❌ failure6m 5s 664ms
e2e/exam/test-exam/TestExamParticipation.spec.ts
ts.Test exam participation › Early Hand-in › Participates as a student in a registered test exam❌ failure6m 7s 299ms
ts.Test exam participation › Early Hand-in › Using exercise sidebar to navigate within exam❌ failure6m 8s 407ms
e2e/exam/test-exam/TestExamTestRun.spec.ts
ts.Test exam test run › Manage a test run › Conducts a test run❌ failure6m 5s 260ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assessment Pull requests that affect the corresponding module client Pull requests that update TypeScript code. (Added Automatically!) exam Pull requests that affect the corresponding module modeling Pull requests that affect the corresponding module quiz Pull requests that affect the corresponding module server Pull requests that update Java code. (Added Automatically!)
Projects
Status: Work In Progress
Development

Successfully merging this pull request may close these issues.

2 participants