- 
                Notifications
    
You must be signed in to change notification settings  - Fork 348
 
          Feature: Only allow privileged admin features after passkey login
          #11464
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Draft
      
      
            florian-glombik
  wants to merge
  51
  commits into
  develop
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
feature/general/only-allow-privileged-admin-features-after-passkey-login
  
      
      
   
  
    
  
  
  
 
  
      
    base: develop
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Draft
            
            
  
    Feature: Only allow privileged admin features after passkey login
  
  #11464
              
                    florian-glombik
  wants to merge
  51
  commits into
  develop
from
feature/general/only-allow-privileged-admin-features-after-passkey-login
  
      
      
   
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    …in-features-after-passkey-login # Conflicts: # src/main/java/de/tum/cit/aet/artemis/core/dto/UserDTO.java # src/main/webapp/app/core/admin/admin.routes.ts # src/main/webapp/app/shared/constants/authority.constants.ts
…vileged-admin-features-after-passkey-login
          End-to-End (E2E) Test Results Summary
 
  | 
    |||||||||||||||||||||||||||||||||||||||||||||||||||
… logged in with passkey
          End-to-End (E2E) Test Results Summary
 
  | 
    ||||||||||||||||||||||||||||||||||||||||||||||||
      
        
      
      
  
    10 tasks
  
          End-to-End (E2E) Test Results Summary
 
  | 
    ||||||||||||||||||||||||||||||||||||||||||||||||||||||
…in-features-after-passkey-login
…in-features-after-passkey-login
          End-to-End (E2E) Test Results Summary | 
    
…in-features-after-passkey-login
      
        
      
      
  
    8 tasks
  
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    client
  Pull requests that update TypeScript code. (Added Automatically!) 
  
    core
  Pull requests that affect the corresponding module 
  
    database
  Pull requests that update the database. (Added Automatically!). Require a CRITICAL deployment. 
  
    server
  Pull requests that update Java code. (Added Automatically!) 
  
    tests
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Checklist
General
Server
Client
Motivation and Context
Compared to passwords based mechanisms, Artemis leverages the higher usability and security of passkeys to improve the security of privileged actions. The enforcement of higher authentication requirements for privileged aligns with the principles set out in the NIS2 Directive that is further specified in 11.3.2a and 11.6.2f of the Commission Implementing Regulation (EU) 2024/2690
See also the respective implementation guidance
This means for Artemis
Privileged users (handling administrators in this PR), who are capable of altering course content, user data or system configurations (administrators), can only perform sensitive actions when authenticated via passkey.
Administrators will only be able to access that information if the passkey was previously approved by a superAdmin (this new Role will be introduced in a future PR), for now there is no UI, just a flag in the database that has to be manually set.
Description
Steps for Testing
Prerequisites:
Testserver States
You can manage test servers using Helios. Check environment statuses in the environment list. To deploy to a test server, go to the CI/CD page, find your PR or branch, and trigger the deployment.
Review Progress
Performance Review
Code Review
Manual Tests
Test Coverage
TODO
Screenshots
TODO