-
Notifications
You must be signed in to change notification settings - Fork 2
(dev) Add fluentbit to dev site. #940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
930311a
to
d9835b7
Compare
d9835b7
to
a6cc3e2
Compare
c966b91
to
828b1a9
Compare
828b1a9
to
3040c79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand the title of this PR. The bundle being modified isn't included by any cluster. Is the intent to deploy fluentbit on all dev clusters?
3040c79
to
687483a
Compare
687483a
to
bf2a059
Compare
Yes, @jhoblitt, and next steps should be to add fluent-bit to the ls and cp. |
541d241
to
edd890d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks ok, but i want to confirm it was tested in dev. (I cant see the ns)
scratch that, I can see the ns |
edd890d
to
d0ce1dd
Compare
d0ce1dd
to
2cc2866
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This pull request introduces significant updates to the Fluent Bit configuration and deployment files to improve logging, monitoring, and customization for Kubernetes clusters. The changes focus on removing outdated configurations, adding new filters and parsers, and enhancing Helm chart customizations for specific environments.
Removal of outdated configurations:
fleet/lib/fluent-bit-kube-pre/fleet.yaml
: Removed thedefaultNamespace
,labels
,namespaceLabels
, andhelm
configurations, includingtimeoutSeconds
andwaitForJobs
. These are no longer required.fleet/lib/fluent-bit-kube-pre/manifests/externalsecret-fluentbit-kube-cred.yaml
: Deleted theExternalSecret
configuration for Fluent Bit credentials, as credentials are no longer managed this way.Enhanced Helm chart customizations:
fleet/lib/fluent-bit-kube/fleet.yaml
: AddedtargetCustomizations
for thedev
environment, allowing cluster-specific Helm values to be applied.Improved Fluent Bit configuration:
fleet/lib/fluent-bit-kube/values.yaml
: Updatedconfig
to replace thesystemd
input with atail
input for kubelet logs, added new filters for Kubernetes metadata cleanup, and introduced new parsers forauditd_line
andsyslog_line
formats. [1] [2]fleet/lib/fluent-bit-kube/values.yaml
: Enhanced HTTP server settings withHTTP_Max_Connections
andHTTP_Buffer_Size
for better performance.Monitoring improvements:
fleet/lib/fluent-bit-kube/values.yaml
: Added a new labelprometheus.io/cluster
to theserviceMonitor
configuration for better integration with Prometheus.Pending PR: #934