Skip to content

Commit 21640ac

Browse files
committed
fix(webserver): Validate header inputs
1 parent 9e61fa7 commit 21640ac

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

libraries/WebServer/src/WebServer.cpp

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -502,6 +502,16 @@ void WebServer::stop() {
502502
}
503503

504504
void WebServer::sendHeader(const String &name, const String &value, bool first) {
505+
if (name.indexOf('\r') != -1 || name.indexOf('\n') != -1) {
506+
log_e("Invalid character in HTTP header name");
507+
return;
508+
}
509+
510+
if (value.indexOf('\r') != -1 || value.indexOf('\n') != -1) {
511+
log_e("Invalid character in HTTP header value");
512+
return;
513+
}
514+
505515
RequestArgument *header = new RequestArgument();
506516
header->key = name;
507517
header->value = value;

0 commit comments

Comments
 (0)