Adding open folder button for mods. #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luciusDXL
requested changes
Oct 24, 2024
| { | ||
| if (s_modsRead) { return; } | ||
| // Reuse the cached mods unless no mods have been read yet. | ||
| if (s_modsRead and s_mods.size() > 0) { return; } |
There was a problem hiding this comment.
This should be && instead of and
| modLoader_read(); | ||
| } | ||
|
|
||
| #ifdef _WIN32 |
There was a problem hiding this comment.
use osShellExecute() from system.h, that way you don't need to include windows.h here.
There was a problem hiding this comment.
Switched to osShellExecute
luciusDXL
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add open folder buttons in the mod section.