Replays POC #492

ifeldshteyn · 2025-02-26T06:40:26Z

This is a POC replay code that is compatible with 1.15

Things to try
The replay section is in **Settings --> Replays **

Try playing the built-in secbase demo. See if it works for you
Try recording any demo and playing it back. Can be either built-in missions or the mods (you can either check Record box or Record All box)
Ensure you have Playback speed up/slowdown buttons set under** Settings-->Inputs**
Try playing back any demo and using the speedup/slowdown (Default: Numpad +/- )
Test whether you can totally pause the demo by going below 30 FPS with Numpad - or make it Fast Forward (go above 240 FPS - ie: use VSYNC off).
Try turning on and off the update visualization (Ex: how many main loop cycles you've played back).

…lays.

… into replays

… dark fores assets.

luciusDXL

Approved, will push once tested locally.

jerethk · 2025-03-10T12:31:18Z

Wow this is epic
Well done

jerethk · 2025-03-10T12:35:06Z

TheForceEngine/TFE_DarkForces/Actor/mousebot.cpp

 	static MouseBot* s_curMouseBot;
 	static s32 s_mouseNum = 0;

+	void mousebot_resetNum()


I've noticed that Lucius adds a // TFE comment above new functions and variables that have been added, it helps us see what did not come from vanilla
I've been trying to do the same
I think it would be good if you could do this as well, where possible

jerethk · 2025-03-10T12:41:54Z

TheForceEngine/TFE_DarkForces/player.cpp

 		s_playerInfo.health      = pickup_addToValue(0, 100, s_healthMax);
 		s_playerInfo.healthFract = 0;
 		s_batteryPower = s_batteryPowerMax;
+		// Always reset player ticks on init for replay consistency


Add "TFE" following Lucius' convention

jerethk · 2025-03-10T12:42:22Z

TheForceEngine/TFE_DarkForces/mission.cpp


 	void mission_exitLevel()
 	{
+		// Force the game to exit the replay modes in case you try to exit through the menu / console


Add "TFE" following Lucius' convention (you get the picture) :-)

jerethk · 2025-03-10T12:43:40Z

TheForceEngine/TFE_DarkForces/weaponFireFunc.cpp

 	extern void weapon_animateOnOrOffscreen(MessageType msg);
 	JBool computeAutoaim(fixed16_16 xPos, fixed16_16 yPos, fixed16_16 zPos, angle14_32 pitch, angle14_32 yaw, s32 variation);

+	// Ensure that the weapon is reset to the default states for replays


jerethk · 2025-03-10T12:49:06Z

TheForceEngine/TFE_Input/replay.cpp

@@ -0,0 +1,1143 @@
+#include <TFE_Input/replay.h>


Just asking the question - is TFE_Input the appropriate place for this, or should you create a new directory and namespace called TFE_Replay ?

What do you think @luciusDXL

I think we decided to let it exist here for now and potentially refactor it later.

jerethk · 2025-03-10T12:54:09Z

TheForceEngine/TFE_Input/replay.cpp

+
+		// This is not really needed but for replay comparison reset the turret/mouse task IDs
+		TFE_DarkForces::mousebot_resetNum();
+		TFE_DarkForces::turret_resetNum();


Are you sure that you don't need to do the same for the other enemies?
It looks like welders, dragons, dark troopers also are numbered

jerethk · 2025-03-10T12:57:47Z

TheForceEngine/TFE_DarkForces/Actor/mousebot.cpp

-				local(moveMod)->target.yaw = local(odd) ? (local(obj)->yaw + deltaYaw) : (local(obj)->yaw - deltaYaw);
-
+				local(moveMod)->target.yaw = local(odd) ? (local(obj)->yaw + deltaYaw) : (local(obj)->yaw - deltaYaw);				
+				


Now it is my turn to nit pick :-)
There seem to be a lot of this in your diffs -- meaningless whitespaces added to lines
I think it would be good to revert as many of them as possible, so your PR commit does not have a whole lot of unnecessary diffs
(Would help in the future if anybody, including yourself, needs to search through the diff while bug hunting etc.)

jerethk · 2025-03-10T12:58:20Z

TheForceEngine/TFE_DarkForces/GameUI/pda.cpp

 			s_framebuffer = ldraw_getBitmap();
 			lcanvas_getBounds(&s_viewBounds);
-
+				


Another one

jerethk · 2025-03-10T12:58:28Z

TheForceEngine/TFE_DarkForces/GameUI/pda.cpp

 		// Draw the overlay *behind* the main view - which means we must blit it to the view.
 		pda_drawOverlay();
-
+		


a couple more

jerethk · 2025-03-10T12:58:52Z

TheForceEngine/TFE_DarkForces/playerCollision.cpp

Karjala22 and others added 30 commits November 26, 2024 15:26

Initial POC commit of replay code

18421a5

Added more debug logs and update tick recording

9ba869b

Working version of replays.

5d4f089

Working version of demo replays. Still rare issues with long term rep…

f9b9a33

…lays.

Add replay POC

c647178

Temp muting logging for events

f705b90

updating projet files

e425b75

Updating Cmakelist

e47d5d1

updating project and merging some files

c6cd639

Ignoring modcache

83728b3

Merge of 1.15 code

fef63e9

More logging cleanup and simplifying code.

83b0bba

More merging of the 1.15 code.

bde3e4f

Additional Merging

e8638e7

updating ui and filters

52360e6

ensuring version is 141 instead of 143

5759a7c

Merge branch 'master' into replays

a4af801

Removing sdl import

7a3c270

Merge branch 'replays' of https://github.com/ifeldshteyn/TheForceEngine…

3dd429a

… into replays

Removed unused dependencies

bbcf767

Removing unreachable code

c43f888

Removing inused includes

5832e6d

Updating strcpy call

62ce1ac

Don't open folder in linux

d02c738

Remove stale replay logging

01a0ba0

Fix up pathing for linux

cc3af63

Updating UI to support linux and change the mod checking behavior for…

8ebfd45

… dark fores assets.

Change functinoality of mod checker.

1068024

temp debug logging

8589ab6

Rewriting log

dd96465

Karjala22 added 2 commits March 8, 2025 14:09

Merge of 1.15 code

d225050

Minor cleanup

d530d12

luciusDXL approved these changes Mar 8, 2025

View reviewed changes

Karjala22 added 21 commits March 8, 2025 18:11

Removing spurious log messages

626fe4a

Adding replay test mechanism

60cb5e3

Ignore any replays

de69d8e

fixing tests workflow

f967481

Fix path

36e00f0

more debug

a3ac19e

more workflow testing

3918af2

More workflow debugging

a985321

More testing

ea75130

workflow fix

54df93d

more bug fixing

cc3832b

more workflow testing

8a98030

more workflow test

f86f99d

add cmake Tests folder

11f692a

testing

ebd2126

updating

7d7408b

more tests

d408ada

top fix

83ac59a

test

d7af3dd

log is ignored - changing to txt

c090e8b

Disable tests through actions.

91f9b34

jerethk reviewed Mar 10, 2025

View reviewed changes

Karjala22 added 2 commits March 10, 2025 14:27

Remove mousebot and turret number checking

24704d7

Added testing

fc68b8a

luciusDXL approved these changes Mar 22, 2025

View reviewed changes

luciusDXL merged commit f328121 into luciusDXL:master Mar 22, 2025
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Replays POC #492

Replays POC #492

Uh oh!

ifeldshteyn commented Feb 26, 2025 •

edited

Loading

Uh oh!

luciusDXL left a comment

Uh oh!

jerethk commented Mar 10, 2025 •

edited

Loading

Uh oh!

jerethk Mar 10, 2025

Uh oh!

jerethk Mar 10, 2025

Uh oh!

jerethk Mar 10, 2025

Uh oh!

jerethk Mar 10, 2025

Uh oh!

jerethk Mar 10, 2025

Uh oh!

luciusDXL Mar 17, 2025

Uh oh!

jerethk Mar 10, 2025

Uh oh!

jerethk Mar 10, 2025

Uh oh!

jerethk Mar 10, 2025

Uh oh!

jerethk Mar 10, 2025

Uh oh!

jerethk Mar 10, 2025

Uh oh!

Uh oh!

Uh oh!

		local(moveMod)->target.yaw = local(odd) ? (local(obj)->yaw + deltaYaw) : (local(obj)->yaw - deltaYaw);

		local(moveMod)->target.yaw = local(odd) ? (local(obj)->yaw + deltaYaw) : (local(obj)->yaw - deltaYaw);

		s_framebuffer = ldraw_getBitmap();
		lcanvas_getBounds(&s_viewBounds);

		// Draw the overlay behind the main view - which means we must blit it to the view.
		pda_drawOverlay();

Replays POC #492

Replays POC #492

Uh oh!

Conversation

ifeldshteyn commented Feb 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luciusDXL left a comment

Choose a reason for hiding this comment

Uh oh!

jerethk commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ifeldshteyn commented Feb 26, 2025 •

edited

Loading

jerethk commented Mar 10, 2025 •

edited

Loading