Add Flatpak CI #507
Draft
Add Flatpak CI #507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeSmarter
reviewed
Mar 25, 2025
Comment on lines
+73
to
+74
| sed -i "s!luciusDXL/TheForceEngine!${{ github.repository }}!" io.github.theforceengine.tfe.yml && \ | ||
| sed -i "s/tag: v.*/commit: ${{ github.sha }}/" io.github.theforceengine.tfe.yml |
There was a problem hiding this comment.
For better readability and manageability I would like to see this patching externalized into a file. Unfortunately, the workflows infrastructure does not provide a programmatic file editor. Anyhow, you could condense these two sed scripts into one call:
sed -i "s!luciusDXL/TheForceEngine!${{ github.repository }}!;\
s/tag: v.*/commit: ${{ github.sha }}/" \
io.github.theforceengine.tfe.yml😉
JakeSmarter
reviewed
Mar 25, 2025
Comment on lines
+81
to
+82
| flatpak-builder --install-deps-from=flathub \ | ||
| build --force-clean --install --user io.github.theforceengine.tfe.yml |
There was a problem hiding this comment.
Like below, you may want to use the latest flatpak-builder from Flathub’s org.flatpak.Builder here as well.
Besides, does not flatpak-builder-lint run on every flatpak-builder build command anyway?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently failing due to an unnecessary metadata file in the Flatpak build repo which is missing screenshots. I've craeted a PR over there to remove this if that's okay with the person who contributed it; once that gets merged the Flatpak CI builds will pass here :)
The build does a clever thing where it uses the Flatpak repo as is, thus providing early warning if changes will break the Flatpak builds. To do this, just before building the Flatpak packages it'll patch the manifest to build the latest commit on whatever repository is actually triggering the build; in a PR that should always be the commit on the repo and branch to be merged so those changes are going to get built against whatever the current stable Flatpak build manifest is :)