Colors POC #542
Open
Colors POC #542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luciusDXL
reviewed
Sep 1, 2025
| if (wall->flags1 & WF1_HIDE_ON_MAP) | ||
| { | ||
| color = WCOLOR_INVISIBLE; | ||
| color = TFE_Settings::getMapColorByName("Invisible Wall")->colorMapIndex; |
There was a problem hiding this comment.
I don't really like the idea of doing value lookups by string for every wall when drawing a map. I think there should be a table that is directly indexed that is filled out based on the settings instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POC - allow you to set colors for all automaps.