-
Notifications
You must be signed in to change notification settings - Fork 77
Secret count #570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Secret count #570
Conversation
* Inf Script Calls are now serialized.
* Enable sending messages to a sector via forcescript * Enable sending message to object * Move the message enum to gs_game Makes more sense there
* This means that string arguments are limited to 31 characters.
It turns out that even with fractional ticks, there is still a minimum frame length needed to avoid precision issues.
writeKeyValue_Bool(settings, "autoNextMission", s_gameSettings.df_autoEndMission); | ||
writeKeyValue_Bool(settings, "showKeyUsed", s_gameSettings.df_showKeyUsed); | ||
writeKeyValue_Bool(settings, "showKeyColors", s_gameSettings.df_showKeyColors); | ||
writeKeyValue_Bool(settings, "centerHudPos", s_gameSettings.df_centerHudPosition); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ifeldshteyn @luciusDXL I wonder if, rather than an endless proliferation of new settings (which could overwhelm players), it would be smarter to group them together.
For example, any future logic-related enhancements I add, I will roll into the custom logics setting so that they all enable or disable together. I don't consider it likely that the majority of people will want to have ultra granular control over such things.
Perhaps "show secret count" could be rolled into "show secret found message", and renamed as "show secrets found" or something like that.
Likewise, "show key used" and "show key colours" I think could be rolled into a single setting.
Alternatively, roll all your automap related changes (door colours, secrets, unvisited areas etc.) into a single new setting called "enhanced automap" or similar.
That would be my recommendation going forward
What do you guys think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I definitely agree with this idea. But that can be done as separate PRs.
</ItemGroup> | ||
<PropertyGroup Label="Globals"> | ||
<VCProjectVersion>15.0</VCProjectVersion> | ||
<ProjectGuid>{31CD2991-9EF0-4AA9-AEEB-BA1194D2DAB4}</ProjectGuid> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be excluded.
@@ -0,0 +1,11 @@ | |||
<?xml version="1.0" encoding="utf-8"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be excluded.
…the tick rate, so I restored the tick rate limitation but kept the improved fractional delta-time precision when smooth delta time is enabled.
* Get logic hitpoints * Set hitpoints and projectile * Get and set Velocity
Add a way to show total # of secrets and allow for centering of the HUD data.