feat: Camera Passthrough #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thomas-coldwell Wow, thanks for your great work! All changes will be includes in the next version :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Lukasz 🙌 Thanks for creating such a useful library!
I've reached for this as I needed to apply some affine transforms to an frame from Vision Camera and OpenCV has fantastic utilities for this. As I was getting setup through I noticed that the resulting frame data would be empty. I realised its because we just pass a pointer to the vector's data but once this vector goes out of scope it gets deallocated so we need to memcpy the data into the OpenCV Mat instead.
I've also included a few other handy changes here like some logging to report any errors when invoking the OpenCV functions and spruced up the example app so this can be extended with lots of lovely examples in the future!