Skip to content

Conversation

@remicollet
Copy link
Collaborator

@remicollet remicollet commented Jul 5, 2023

This also make them really readonly

        Property [ public readonly string $libraryVersion ]
        Property [ public readonly int $protocolVersion ]
        Property [ public readonly string $serverVersion ]

BUT it breaks because of call to "write" in the "read" function, which is commented out here
Can you please explain why this (don't see anything similar in php-src) ?

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #51 (2bd0c68) into master (fbbe06a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
+ Coverage   76.82%   76.84%   +0.01%     
==========================================
  Files          17       17              
  Lines        3612     3615       +3     
==========================================
+ Hits         2775     2778       +3     
  Misses        837      837              
Impacted Files Coverage Δ
src/php_pq_object.c 94.28% <ø> (-0.16%) ⬇️
src/php_pqconn.c 67.97% <100.00%> (+0.20%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@m6w6
Copy link
Owner

m6w6 commented Jul 10, 2023

Can you please explain why this (don't see anything similar in php-src) ?

Well, duh... not really, except, using git blame: a3b5ed1

@remicollet
Copy link
Collaborator Author

In old v1.1.1, I don't see any "write" in the "read" method
https://github.com/m6w6/ext-pq/blob/v1.1.1/src/php_pq_object.c#L121

Looks like it was added in big commit cb69b62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants