Skip to content

Feature/build test #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 18, 2022
Merged

Conversation

hakuturu583
Copy link
Contributor

add build test for mros2-mbed.

This workflow was tested by this PR.

Signed-off-by: MasayaKataoka <ms.kataoka@gmail.com>
add build test
…ros2-mbed into feature/build_test

Signed-off-by: MasayaKataoka <ms.kataoka@gmail.com>
Signed-off-by: MasayaKataoka <ms.kataoka@gmail.com>
Signed-off-by: MasayaKataoka <ms.kataoka@gmail.com>
Signed-off-by: MasayaKataoka <ms.kataoka@gmail.com>
@hakuturu583 hakuturu583 marked this pull request as ready for review June 7, 2022 17:03
@takasehideki
Copy link
Member

Hi @hakuturu583 How do you think about my review comments? IOW, could I fix them myself before merging?

@hakuturu583
Copy link
Contributor Author

hakuturu583 commented Jun 18, 2022

How do you think about my review comments? IOW, could I fix them myself before merging?
Sorry.

I will fix it soon.

Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
@hakuturu583
Copy link
Contributor Author

@takasehideki Thank you for pointed out.
I fixed.

Copy link
Member

@takasehideki takasehideki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hakuturu583 your work was perfect! thank you so much!!
I can’t wait this repository will acquire the power of CI :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants