Skip to content

Conversation

cd-Barnes
Copy link

Hey folks, considering more organizations are choosing to force the use of the new fine-grained access tokens, I took a stab at implementing the feature. It's working well on our end. Lmk what you think.

Basically I'm solving this with a new var: github-token-type. If this value is not specified, or classic, then we'll use the old --token arg. If the user passes fine-grained, then we will use the --pat arg that allows the use of fine-grained tokens.

Note that this change also includes the work done in #127. Simply because we needed both fixes. However I'm happy to leave that out and allow discussion to continue over there if that's preferable.

Fixes #160, builds upon #127

@ktdreyer
Copy link
Contributor

ktdreyer commented May 16, 2025

I tested with a fine-grained token today, and my runner registered itself correctly.

Maybe GitHub has updated their runner registration tool to accept fine-grained tokens with --token ? I cannot find the Git history for the setup.sh script to confirm this.

EDIT, apologies I got the name of this script wrong. We pass --token to config.sh, not setup.sh. And that script simply passes its full arguments to bin/Runner.Listener.

@cd-Barnes
Copy link
Author

Hmm interesting. Thanks for the heads up! I'll test as well and report back. If so, I'll close the PR (bit out of date anyway 😆)

@cd-Barnes
Copy link
Author

@ktdreyer and others

Confirmed what you were seeing, seems like Github has updated their tooling and made this change irrelevant. I'll go ahead and close it.

@cd-Barnes cd-Barnes closed this May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature request] Allow use of Fine-grained personal access tokens

2 participants