Skip to content

added HostID Store on memory. #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 22, 2025
Merged

added HostID Store on memory. #476

merged 7 commits into from
Aug 22, 2025

Conversation

yseto
Copy link
Contributor

@yseto yseto commented Aug 21, 2025

  • added HostID Store on memory.
  • environment variable MACKEREL_HOST_ID_STORE and hostIdStore on config YAML.
    • file Same as before (default)
    • memory Host ID on memory. Use in a specific environment

@yseto yseto self-assigned this Aug 21, 2025
@yseto yseto marked this pull request as ready for review August 21, 2025 09:19
yohfee
yohfee approved these changes Aug 22, 2025
View reviewed changes
Copy link

@yohfee yohfee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@yseto yseto merged commit aa4f0af into master Aug 22, 2025
4 checks passed
@yseto yseto deleted the memory-host-id-store branch August 22, 2025 01:30
@yseto
Copy link
Contributor Author

yseto commented Aug 22, 2025

Thanks for your review.

This was referenced Aug 22, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yohfee yohfee yohfee approved these changes

Assignees

@yseto yseto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yseto @yohfee