Add traces get command for trace retrieval #731
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add GetTrace method to mackerelclient.Client interface - Add corresponding mock implementation in MockClient - Supports trace retrieval functionality for upcoming traces command
- Add traces/command.go with CLI definition and subcommand routing - Add traces/app.go with business logic for trace retrieval - Add traces/app_test.go with unit tests using MockClient - Support 'mkr traces get <traceId>' command with JSON output - Include help text and argument validation
- Import traces package in commands.go - Add traces.Command to Commands slice - Enables 'mkr traces' command availability
- Add replace directive to use mackerel-client-go v0.37.4-0.20250921022114-01bdd54dfe06 - This commit references the traces branch of mackerel-client-go - Update go.sum with new dependency checksums - Required for GetTrace method availability until upstream merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added traces get command
TODO
replacedirective in go.mod once mackerel-client-go traces support is officially released