Refactor bindParam callback and validation methods in MysqlTest

Author: ihor-sviziev

lib/internal/Magento/Framework/DB/Test/Unit/DB/Statement/MysqlTest.php

@@ -144,39 +144,64 @@ public function testExecuteWhenParamsAsParameterObject()
         $this->pdoStatementMock->expects($this->exactly(2))
             ->method('bindParam')
             ->willReturnCallback(
-                function (
-                    $arg1,
-                    $arg2,
-                    $arg3,
-                    $arg4,
-                    $arg5
-                ) use (
-                    $param1Value,
-                    $param1DataType,
-                    $param1Length,
-                    $param1DriverOptions
-                ) {
-                    if ($arg1 == ':param1' &&
-                        $arg2 == $param1Value &&
-                        $arg3 == $param1DataType &&
-                        $arg4 == $param1Length &&
-                        $arg5 == $param1DriverOptions) {
-                        return true;
-                    } elseif ($arg1 == ':param2' &&
-                        $arg2 == 'value2' &&
-                        $arg3 == \PDO::PARAM_STR &&
-                        $arg4 == 6 &&
-                        $arg5 == null) {
-                        return true;
-                    }
-                }
+                $this->getBindParamCallback($param1Value, $param1DataType, $param1Length, $param1DriverOptions)
             );
         $this->pdoStatementMock->expects($this->once())
             ->method('execute');
 
         (new Mysql($this->adapterMock, $query))->_execute($params);
     }
 
+    /**
+     * Get callback for bindParam method validation
+     *
+     * @param string $param1Value
+     * @param int $param1DataType
+     * @param int $param1Length
+     * @param string $param1DriverOptions
+     * @return callable
+     */
+    private function getBindParamCallback(
+        string $param1Value,
+        int $param1DataType,
+        int $param1Length,
+        string $param1DriverOptions
+    ): callable {
+        return function ($arg1, $arg2, $arg3, $arg4, $arg5) use (
+            $param1Value,
+            $param1DataType,
+            $param1Length,
+            $param1DriverOptions
+        ) {
+            return $this->validateParam1Binding($arg1, $arg2, $arg3, $arg4, $arg5, $param1Value, $param1DataType, $param1Length, $param1DriverOptions)
+                || $this->validateParam2Binding($arg1, $arg2, $arg3, $arg4, $arg5);
+        };
+    }
+
+    /**
+     * Validate param1 binding arguments
+     */
+    private function validateParam1Binding($arg1, $arg2, $arg3, $arg4, $arg5, $param1Value, $param1DataType, $param1Length, $param1DriverOptions): bool
+    {
+        return $arg1 == ':param1' &&
+            $arg2 == $param1Value &&
+            $arg3 == $param1DataType &&
+            $arg4 == $param1Length &&
+            $arg5 == $param1DriverOptions;
+    }
+
+    /**
+     * Validate param2 binding arguments
+     */
+    private function validateParam2Binding($arg1, $arg2, $arg3, $arg4, $arg5): bool
+    {
+        return $arg1 == ':param2' &&
+            $arg2 == 'value2' &&
+            $arg3 == \PDO::PARAM_STR &&
+            $arg4 == 6 &&
+            $arg5 == null;
+    }
+
     /**
      * Initialize queryString property.
      *