Translate under module overwrite all other place

[mrtuvn]

Summary

Current from my experiences, Magento process translate module as higher priority and will overwrite all other string instead replace only module scope

Examples

Customer Login,Customer Login
Customer Login, Customer Login custom, module, Magento_Customer

The second line instead replace string in module scope will replace all other place outside of module scope.

Proposed solution

translate module should implace into scope module only instead

Expect results
inside module customer -> text "Customer Login custom" used
other places -> will use text "Customer Login"

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @mrtuvn. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant]

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Hotel]

Hello @mrtuvn,

Thanks for the report and collaboration!

We are unable to get the issue, can you please elaborate the issue more with some steps to reproduce, actual and expected result.

Thanks

[mrtuvn]

i think this case can reproduce with add translate above in theme (luma/blank) or any custom theme. You can't reproduce with clean version. You can use translate text for test 2 cases at same time.
Test Case 1:
Add two line below to csv in theme
Then redeploy to verify

"Customer Login","Customer Login"
"Customer Login","Customer Login custom",module,Magento_Customer

Then you go to login page customer
Text should be Customer Login custom -> OK It's works correct

Test Case 2:
Then you add same text translate in module Magento_Catalog to verify
Add code below to file
https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Catalog/view/frontend/templates/product/view/addtocart.phtml

<p><?= __('Customer Login') ?></p>

Expect
line in module catalog should show translate at frontend -> Customer Login

Actual
line in module catalog show Customer Login custom show in frontend

Hope this can help you @engcom-Hotel

[engcom-Hotel]

Hello @mrtuvn,

It seems that the functionality is working as expected. We have looked into the DevDocs, but there is no mention regarding the module-wise translation.

Please let us know in case we missed anything.

Thanks

[mrtuvn]

Yes but in the code base still use module translate but docs not mention any different or benefits of it. From my expect
when you specific module it's should only impact to module area only not impact other place not in scope of module

[engcom-Hotel]

Thanks @mrtuvn for the reply!

On this note, we are confirming this issue.

Thanks