-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Added getScopeCacheKey in order to define the right cache key based on store ID #27142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
matiashidalgo
wants to merge
10
commits into
magento:2.5-develop
Choose a base branch
from
matiashidalgo:mhidalgo/added-scope-cache-key-for-category-repository
base: 2.5-develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
69946cc
Added getScopeCacheKey in order to validate the store ID and return t…
matiashidalgo 4872d68
Fix for Functional tests based on the code updates
matiashidalgo 7949329
Unit test and Functional test for get store id validation on category…
matiashidalgo ffda40b
Coding standard adjustment
matiashidalgo ce236c4
Merge branch '2.4-develop' into mhidalgo/added-scope-cache-key-for-ca…
slavvka c72ec81
Merge branch '2.4-develop' into mhidalgo/added-scope-cache-key-for-ca…
slavvka fa481b1
fix unit test
engcom-Echo 215db8b
Merge branch '2.5-develop' of github.com:magento/magento2 into mhidal…
matiashidalgo eba2664
Update dev/tests/integration/testsuite/Magento/Catalog/Model/Category…
matiashidalgo 1564b59
Merge branch '2.5-develop' into mhidalgo/added-scope-cache-key-for-ca…
engcom-Dash File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.