Skip to content

Remove redundant methods #29147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: 2.4-develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
0a559c7
remove redundant methods
Usik2203 Jul 15, 2020
076a13e
revert return parament
Usik2203 Jul 15, 2020
865339e
remove redundunt description
Usik2203 Jul 16, 2020
59c9adb
Remove redundant methods - static tests fix.
engcom-Foxtrot Aug 26, 2020
bcabc99
Merge branch '2.4-develop' into remove-redundant-methods-1
engcom-Lima Jun 7, 2023
3202cf9
Merge branch '2.4-develop' into remove-redundant-methods-1
engcom-Lima Jul 26, 2023
2cfe241
Merge branch '2.4-develop' into remove-redundant-methods-1
engcom-Echo Aug 7, 2023
5242810
Resolve Static tests failure
glo24157 Aug 9, 2023
bcbff74
Merge branch '2.4-develop' into remove-redundant-methods-1
engcom-Hotel Jan 19, 2024
8683096
Merge branch '2.4-develop' into remove-redundant-methods-1
engcom-Hotel Apr 14, 2025
e3eca51
Merge branch '2.4-develop' into remove-redundant-methods-1
engcom-Charlie Apr 24, 2025
2e5d7b7
Fixed the static tests and updated copyright
engcom-Charlie Apr 24, 2025
9ad34c7
Merge branch 'remove-redundant-methods-1' of https://github.com/Usik2…
engcom-Charlie Apr 24, 2025
b76bb48
Worked on review comments
engcom-Charlie Apr 25, 2025
8fd5534
Merge branch '2.4-develop' into remove-redundant-methods-1
engcom-Charlie Apr 28, 2025
610c638
Merge branch '2.4-develop' into remove-redundant-methods-1
engcom-Charlie Apr 29, 2025
9c98c65
Merge branch '2.4-develop' into remove-redundant-methods-1
engcom-Charlie May 20, 2025
2153ce4
Merge branch '2.4-develop' into remove-redundant-methods-1
engcom-Charlie Jun 25, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,22 +1,28 @@
<?php
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
* Copyright 2016 Adobe
* All Rights Reserved.
*/

namespace Magento\AsynchronousOperations\Controller\Adminhtml\Index;

class Index extends \Magento\Backend\App\Action
use Magento\Backend\App\Action;
use Magento\Backend\App\Action\Context;
use Magento\Framework\App\Action\HttpGetActionInterface;
use Magento\Framework\View\Result\Page;
use Magento\Framework\View\Result\PageFactory;

class Index extends Action implements HttpGetActionInterface
{
/**
* Authorization level of a basic admin session
*
* @see _isAllowed()
*/
const ADMIN_RESOURCE = 'Magento_Logging::system_magento_logging_bulk_operations';
public const ADMIN_RESOURCE = 'Magento_Logging::system_magento_logging_bulk_operations';

/**
* @var \Magento\Framework\View\Result\PageFactory
* @var PageFactory
*/
private $resultPageFactory;

Expand All @@ -26,33 +32,24 @@ class Index extends \Magento\Backend\App\Action
private $menuId;

/**
* Details constructor.
* @param \Magento\Backend\App\Action\Context $context
* @param \Magento\Framework\View\Result\PageFactory $resultPageFactory
* @param Context $context
* @param PageFactory $resultPageFactory
* @param string $menuId
*/
public function __construct(
\Magento\Backend\App\Action\Context $context,
\Magento\Framework\View\Result\PageFactory $resultPageFactory,
Context $context,
PageFactory $resultPageFactory,
$menuId = 'Magento_AsynchronousOperations::system_magento_logging_bulk_operations'
) {
$this->resultPageFactory = $resultPageFactory;
$this->menuId = $menuId;
parent::__construct($context);
}

/**
* @inheritDoc
*/
protected function _isAllowed()
{
return parent::_isAllowed();
}

/**
* Bulk list action
*
* @return \Magento\Framework\View\Result\Page
* @return Page
*/
public function execute()
{
Expand Down
19 changes: 4 additions & 15 deletions app/code/Magento/Sales/Block/Adminhtml/Order/Create/Newsletter.php
Original file line number Diff line number Diff line change
@@ -1,23 +1,20 @@
<?php
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
* Copyright 2011 Adobe
* All Rights Reserved.
*/
namespace Magento\Sales\Block\Adminhtml\Order\Create;

/**
* Adminhtml sales order create newsletter block
*
* @api
* @author Magento Core Team <core@magentocommerce.com>
* @since 100.0.2
*/
class Newsletter extends \Magento\Sales\Block\Adminhtml\Order\Create\AbstractCreate
class Newsletter extends AbstractCreate
{
/**
* Constructor
*
* @return void
* @inheritdoc
*/
protected function _construct()
{
Expand All @@ -44,12 +41,4 @@ public function getHeaderCssClass()
{
return 'head-newsletter-list';
}

/**
* {@inheritdoc}
*/
protected function _toHtml()
{
return parent::_toHtml();
}
}