Skip to content

Improve JS Translation DataProviderTest #32689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: 2.4-develop
Choose a base branch
from
Open

Improve JS Translation DataProviderTest #32689

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
801e90d
Improve JS Translation DataProviderTest
navarr Apr 7, 2021
ef9539a
Use `self` instead of `static` for referring to constants
navarr Apr 8, 2021
d0a841b
Merge branch '2.4-develop' into patch-4
engcom-Charlie Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions dev/tests/integration/testsuite/Magento/Translation/Model/Js/DataProviderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@
*/
class DataProviderTest extends TestCase
{
private const STRING_TO_TRANSLATE = 'Proceed to Checkout';

private const STRING_TRANSLATION = 'Proceed to Checkout - Translated';

/**
* @var StringUtils
*/
Expand Down Expand Up @@ -52,12 +56,11 @@ protected function setUp(): void
*/
public function testGetData()
{
$expectedDictionary = ['Proceed to Checkout' => 'Proceed to Checkout - Translated'];

$this->stringUtils->saveTranslate('Proceed to Checkout', 'Proceed to Checkout - Translated');
$this->stringUtils->saveTranslate(self::STRING_TO_TRANSLATE, self::STRING_TRANSLATION);
$this->translate->setLocale('en_US')->loadData('frontend', true);
$dictionary = $this->translationDataProvider->getData('Magento/luma');
$this->assertEquals($expectedDictionary, $dictionary);
$this->assertArrayHasKey(self::STRING_TO_TRANSLATE, $dictionary);
$this->assertEquals(self::STRING_TRANSLATION, $dictionary[self::STRING_TO_TRANSLATE]);
}

/**
Expand All @@ -66,7 +69,7 @@ public function testGetData()
protected function tearDown(): void
{
try {
$this->stringUtils->deleteTranslate('Proceed to Checkout');
$this->stringUtils->deleteTranslate(self::STRING_TO_TRANSLATE);
} catch (NoSuchEntityException $exception) {
// translate already deleted
}
Expand Down