Skip to content

Price tiers calculated on 2 decimals even when prices of 4 decimals are entered issue solved. #37942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

JettyRohanAditya
Copy link
Contributor

Description (*)

  • magento2/app/code/Magento/Quote/Model/Quote/Item/AbstractItem.php
  • Here there is a function calcRowTotal() that is setting the total
  • there $total = $this->priceCurrency->round($this->getCalculationPriceOriginal()) * $qty; is setting the total by multiplying get calculation price with the quantity
  • here they are rounding the get calculation price
  • And that round is from
  • magento2/lib/internal/Magento/Framework/Pricing/PriceCurrencyInterface.php
  • There is one implementation of this at magento2/app/code/Magento/Directory/Model/PriceCurrency.php
  • Here they were given precision as 2 which was doing the wrong calculations,
  • I changed it with self::DEFAULT_PRECISION which is 4.
  1. For the Front End
  • magento2/app/code/Magento/Catalog/view/base/web/js/price-utils.js
  • changed form
  • precision = isNaN(format.requiredPrecision = Math.abs(format.requiredPrecision)) ? 4 : format.requiredPrecision;
  • To
  • precision = !isNaN(format.requiredPrecision = Math.abs(format.requiredPrecision)) ? format.requiredPrecision : 4;
  • magento2/lib/internal/Magento/Framework/Pricing/PriceCurrencyInterface.php
  • changed CONST DEFAULT_PRECISION = 4; from 2.
  1. Fixes Price tiers calculated on 2 decimals even when prices of 4 decimals are entered #15772

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 31, 2023

Hi @JettyRohanAditya. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Progress: pending review labels Aug 31, 2023
@JettyRohanAditya
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@JettyRohanAditya
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

…imals-even-when-prices-of-4-decimals-are-entered
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Price tiers calculated on 2 decimals even when prices of 4 decimals are entered
1 participant