Ignore WouldBlock I/O error kind #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this change allows to fix some
WouldBlockerrors while parsing multipart data. This only relates to Rocket 0.4, 0.5 is apparently not affected.I theory this should be fixed in either Hyper or Rocket, but Hyper is outdated and Rocket 0.4 is not very active (which I can understand), I'm looking forward to seeing 0.5 out. In the meanwhile, there is this tiny change which at least covers our issue with multipart upload.
In order to test that I used
dd if=/dev/zero bs=1000000 count=2 | pv -L 3k | curl -k 'https://localhost:8000' -v -F file=@/dev/stdin.Artificially limiting the bandwidth (with
pv) is the key to reproduce the problem.PR open to suggestions.