You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@iharshyadav
Thanks for working on this and for the quick turnaround.
I think this PR fixes the default duration randomness issue (Math.random() * 3 + 4), but it may not fully solve timing drift in cases where duration/delay are passed explicitly (for example, the server-connections repro). In those cases, changing the default duration has no effect.
The remaining drift seems to come from repeatDelay: 0 being hardcoded. Beams with different duration/delay values can look aligned in the first cycle, then gradually go out of phase.
Would you be able to add a follow-up commit in this PR to expose repeatDelay (and optionally repeat) as props so explicit timing setups can stay synchronized across cycles?
@iharshyadav
Tysm for the contribution.
I added a couple of small follow-up tweaks on top, and I think this is ready to merge now. LGTM, so I'll go ahead and merge this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes inconsistent animation timing in Animated Beam when multiple beams are rendered without explicitly setting a duration.
Root Cause
The component used a random default duration per instance (
Math.random() * 3 + 4), which made beams drift out of sync.Fix
durationto a deterministic value:5durationFiles Changed
Validation
Related
Closes #840