Generating QR-Codes for TOTP locally, instead of relying on a remote service. #6652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
During a previous update of directorytree/ldaprecord (d479d18) the composer.json and composer.lock were created incorrectly. ldaprecord 2.20.5 is the version currently distributed, but this is not reflected in the composer.json.
Currently mailcow uses a third-party remote service to create qr-codes. The qr codes can easily be created locally without contacting a remote server. The TwoFactorAuth lib, that currently uses the remote service also supports bacon-qr-code
psuet
force-pushed
the
fix/local-qr-code
branch
from
b94765d to
36ea8e7
Compare
|
Rebased and fixed conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution Guidelines
What does this PR include?
Short Description
This PR exchanges the currently used
QRServerProviderfor generating TOTP / HOTP Tokens with theBaconQrCodeProvider.The
QRServerProvideruses a remote service atapi.qrserver.comwhich is not ideal (see also #6094). bacon-qr-code can create qr codes locally, without any remote calls.Additionally, this MR fixes a consistency problem with the current composer.json / composer.lock (without any updates to packages)
Affected Containers
Did you run tests?
What did you test?
TOTP QR Code Generation for Users / Admins
What were the final results? (Awaited, got)
TOTP QR Code works as before, but does not use a remote service anymore.