Merge pull request #118 from mailtrap/email-logs-filters-fix

Fix Email Logs API multi-value filters query string to use brackets notation

Author: mklocek

src/__tests__/lib/api/resources/EmailLogs.test.ts

@@ -137,8 +137,8 @@ describe("lib/api/resources/EmailLogs: ", () => {
       const baseUrl = `${GENERAL_ENDPOINT}/api/accounts/${accountId}/email_logs`;
       const expectedQuery =
         "filters[category][operator]=equal" +
-        "&filters[category][value]=Welcome%20Email" +
-        "&filters[category][value]=Forget%20Password";
+        "&filters[category][value][]=Welcome%20Email" +
+        "&filters[category][value][]=Forget%20Password";
       const expectedUrl = `${baseUrl}?${expectedQuery}`;
 
       expect.assertions(2);

src/lib/api/resources/EmailLogs.ts

@@ -14,7 +14,7 @@ const { GENERAL_ENDPOINT } = CLIENT_SETTINGS;
 /**
  * Serialize query params for email logs list. Uses qs for deepObject-style
  * bracket notation (e.g. filters[sent_after]=..., filters[to][operator]=...)
- * with repeated keys for array values.
+ * with bracket notation for arrays (Rails-style, e.g. filters[category][value][]=foo).
  */
 function serializeEmailLogsParams(params: EmailLogsListParams): string {
   const query: Record<string, unknown> = {};
@@ -25,7 +25,7 @@ function serializeEmailLogsParams(params: EmailLogsListParams): string {
     query.filters = params.filters;
   }
   return qs.stringify(query, {
-    arrayFormat: "repeat",
+    arrayFormat: "brackets",
     encode: true,
     encodeValuesOnly: true,
   });