incorrect credentials doesn't show data-test-error-message #2969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves error when trying to log in with with incorrect credentials: "Uncaught (in promise) TypeError: Response.clone: Body has already been consumed."
|
Unfortunately, the test logging in with incorrect credentials shows an error doesn't reveal the error. It is only visible as missing in the browser (Firefox 137.0.1 / Chromium 135.0.7049.52) itself. |
|
As a reminder: using |
|
Well spotted! I'd like to hold off on this though because using the I've been thinking about a migration path for a while but it's not exactly as easy as I initially thought because we rely on the response internally and simply cloning it leads to a very weird API. Let's leave this PR open as a reminder, I probably won't merge it however. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves error when trying to log in with with incorrect credentials: "Uncaught (in promise) TypeError: Response.clone: Body has already been consumed."