Skip to content

Added input defaults and automatic build on pre-commit #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added input defaults and automatic build on pre-commit #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa109a9
added auto build and default input values
samueljim May 24, 2021
2d05de4
added comments explaining merging
samueljim May 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,13 @@
"start": "sirv public",
"validate": "svelte-check"
},
"pre-commit": [ "validate", "build" ],
Copy link
Contributor

@jamesrplee jamesrplee May 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need pre-commit as a dependency? What's it offering for the boilerplate?

"devDependencies": {
"@rollup/plugin-commonjs": "^17.0.0",
"@rollup/plugin-node-resolve": "^11.0.0",
"@rollup/plugin-typescript": "^8.0.0",
"@tsconfig/svelte": "^1.0.0",
"pre-commit": "^1.2.2",
"rollup": "^2.3.4",
"rollup-plugin-css-only": "^3.1.0",
"rollup-plugin-livereload": "^2.0.0",
Expand Down
2 changes: 1 addition & 1 deletion public/build/bundle.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 11 additions & 5 deletions src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,19 @@
import App from './App.svelte';

// You can define default input values here. The values here will be used if no value is given.
const inputs = {
...{
Copy link
Contributor

@jamesrplee jamesrplee May 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defining an object and then instantly spreading it seems a bit dank. Couldn't we just do?

const props = {
  foo: 'bar',
   ...window.templateProps
}

headline: 'Hello World',
showLogos: true,
backgroundImage: ''
},
...window.templateProps
}

const app = new App({
target: document.body,
props: {
templateProps: window.templateProps || {
headline: 'Hello World',
showLogos: true,
backgroundImage: ''
}
templateProps: inputs
}
});

Expand Down