-
Notifications
You must be signed in to change notification settings - Fork 633
Use isomorphic fetch #506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Use isomorphic fetch #506
Conversation
👋 Hi from Notion's API team! Thanks @huv1k @sv2dev for bumping this issue, looks like it's been open for a while. I don't have much context on this yet, though it looks like you have merge conflicts. I recently added a test that relies on us overriding the fetch passed to the |
26ff5c4
to
7abf2aa
Compare
Hey @ksinder, thanks for picking this up. |
Getting rid of the |
It should be sufficient to run the TypeScript tests. This way we don't have to run a build before executing the unit tests.
7abf2aa
to
3f53ab4
Compare
Okay, I reverted the typings and client parameter related stuff. Now we should be able to use a different |
Since
fetch
is stable in the current LTS version of Node, I don't see any good reason for using node-fetch or any other solution than the web standard.