Do not ask for location on Windows even though no location feature is used

karelklic · web-flow · commit a2469da5ce9f · 2025-04-06T21:30:52.000+02:00
Workaround for: Baseflow#1394
diff --git a/permission_handler_windows/windows/permission_handler_windows_plugin.cpp b/permission_handler_windows/windows/permission_handler_windows_plugin.cpp
@@ -65,7 +65,6 @@ class PermissionHandlerWindowsPlugin : public Plugin {
   winrt::fire_and_forget IsBluetoothServiceEnabled(std::unique_ptr<MethodResult<>> result);
 
   winrt::Windows::Devices::Geolocation::Geolocator geolocator;
-  winrt::Windows::Devices::Geolocation::Geolocator::PositionChanged_revoker m_positionChangedRevoker;
 };
 
 // static
@@ -87,10 +86,6 @@ void PermissionHandlerWindowsPlugin::RegisterWithRegistrar(
 }
 
 PermissionHandlerWindowsPlugin::PermissionHandlerWindowsPlugin(){
-  m_positionChangedRevoker = geolocator.PositionChanged(winrt::auto_revoke,
-    [this](Geolocator const& geolocator, PositionChangedEventArgs e)
-    {
-    });
 }
 
 PermissionHandlerWindowsPlugin::~PermissionHandlerWindowsPlugin() = default;

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,6 @@ class PermissionHandlerWindowsPlugin : public Plugin {`
`65`	`65`	`winrt::fire_and_forget IsBluetoothServiceEnabled(std::unique_ptr<MethodResult<>> result);`
`66`	`66`
`67`	`67`	`winrt::Windows::Devices::Geolocation::Geolocator geolocator;`
`68`		`- winrt::Windows::Devices::Geolocation::Geolocator::PositionChanged_revoker m_positionChangedRevoker;`
`69`	`68`	`};`
`70`	`69`
`71`	`70`	`// static`
`@@ -87,10 +86,6 @@ void PermissionHandlerWindowsPlugin::RegisterWithRegistrar(`
`87`	`86`	`}`
`88`	`87`
`89`	`88`	`PermissionHandlerWindowsPlugin::PermissionHandlerWindowsPlugin(){`
`90`		`- m_positionChangedRevoker = geolocator.PositionChanged(winrt::auto_revoke,`
`91`		`- [this](Geolocator const& geolocator, PositionChangedEventArgs e)`
`92`		`- {`
`93`		`- });`
`94`	`89`	`}`
`95`	`90`
`96`	`91`	`PermissionHandlerWindowsPlugin::~PermissionHandlerWindowsPlugin() = default;`