Merge pull request #38012 from mantidproject/diffraction_coverity_fixes

Coverity issue fixes

Author: SilkeSchomann

Framework/Algorithms/src/DiscusMultipleScatteringCorrection.cpp

@@ -1441,7 +1441,7 @@ std::tuple<bool, std::vector<double>> DiscusMultipleScatteringCorrection::scatte
         for (auto &SQWSMapping : currentComponentWorkspaces)
           SQWSMapping.InvPOfQ = SQWSMapping.InvPOfQ->createCopy();
         prepareCumulativeProbForQ(k, newComponentWorkspaces);
-        currentComponentWorkspaces = newComponentWorkspaces;
+        currentComponentWorkspaces = std::move(newComponentWorkspaces);
       }
     }
     auto trackStillAlive =
@@ -1507,7 +1507,7 @@ std::tuple<bool, std::vector<double>> DiscusMultipleScatteringCorrection::scatte
       const double q = qVector.norm();
       const double finalW = fromWaveVector(k) - finalE;
       auto componentWSIt = findMatchingComponent(componentWorkspaces, shapeObjectWithScatter);
-      auto componentWSMapping = *componentWSIt; // to help debugging
+      auto &componentWSMapping = *componentWSIt; // to help debugging
       double SQ = Interpolate2D(componentWSMapping, q, finalW);
       scatteringXSection = m_NormalizeSQ ? scatteringXSection / interpolateFlat(*(componentWSMapping.QSQScaleFactor), k)
                                          : scatteringXSectionFull;

Framework/Crystal/src/RotateSampleShape.cpp

@@ -77,14 +77,14 @@ void RotateSampleShape::exec() {
     g_log.warning() << "Empty goniometer created; will always return an "
                        "identity rotation matrix.\n";
 
-  const auto sampleShapeRotation = gon.getR();
+  const auto &sampleShapeRotation = gon.getR();
   if (sampleShapeRotation == Kernel::Matrix<double>(3, 3, true)) {
     // If the resulting rotationMatrix is Identity, ignore the calculatrion
     g_log.warning("Rotation matrix set via RotateSampleShape is an Identity matrix. Ignored rotating sample shape");
     return;
   }
 
-  const auto oldRotation = ei->run().getGoniometer().getR();
+  const auto &oldRotation = ei->run().getGoniometer().getR();
   auto newSampleShapeRot = sampleShapeRotation * oldRotation;
   if (isMeshShape) {
     auto meshShape = std::dynamic_pointer_cast<MeshObject>(ei->sample().getShapePtr());