Use smart pointers instead of raw pointers

Author: jclarkeSTFC

Framework/CurveFitting/src/Functions/BSpline.cpp

@@ -61,16 +61,18 @@ void BSpline::resetValidators() {
   auto attStartX = getAttribute("StartX");
   auto attEndX = getAttribute("EndX");
 
-  auto startXValidator = dynamic_cast<BoundedValidator<double> *>(attStartX.getValidator().get());
+  auto startXValidator = std::dynamic_pointer_cast<BoundedValidator<double>>(attStartX.getValidator());
   startXValidator->setUpper(attEndX.asDouble());
 
-  auto endXValidator = dynamic_cast<BoundedValidator<double> *>(attEndX.getValidator().get());
+  auto endXValidator = std::dynamic_pointer_cast<BoundedValidator<double>>(attEndX.getValidator());
   endXValidator->setLower(attStartX.asDouble());
 
   auto breakPointsValidator =
-      dynamic_cast<ArrayBoundedValidator<double> *>(getAttribute("BreakPoints").getValidator().get());
-  breakPointsValidator->setLower(attStartX.asDouble());
-  breakPointsValidator->setUpper(attEndX.asDouble());
+      dynamic_pointer_cast<ArrayBoundedValidator<double>>(getAttribute("BreakPoints").getValidator());
+  if (breakPointsValidator != nullptr) {
+    breakPointsValidator->setLower(attStartX.asDouble());
+    breakPointsValidator->setUpper(attEndX.asDouble());
+  }
 }
 
 /** Execute the function