#38487 Sibling - Bugfix: isDistribution After Divide of Two RaggedWorkspaces (#38494)

Post main-merge

Author: ktactac-ornl

Framework/Algorithms/src/Divide.cpp

@@ -76,9 +76,15 @@ void Divide::performBinaryOperation(const HistogramData::Histogram &lhs, const d
 
 void Divide::setOutputUnits(const API::MatrixWorkspace_const_sptr lhs, const API::MatrixWorkspace_const_sptr rhs,
                             API::MatrixWorkspace_sptr out) {
+
+  if (lhs->isRaggedWorkspace() && rhs->isRaggedWorkspace()) {
+    // if both workspaces are ragged, output workspace `isDistribution` flag will be true
+    out->setDistribution(true);
+  }
   if (rhs->YUnit().empty() || !WorkspaceHelpers::matchingBins(*lhs, *rhs, true)) {
     // Do nothing
   }
+
   // If the Y units match, then the output will be a distribution and will be
   // dimensionless
   else if (lhs->YUnit() == rhs->YUnit() && m_rhsBlocksize > 1) {

Framework/Algorithms/src/Multiply.cpp

@@ -54,8 +54,9 @@ void Multiply::performBinaryOperation(const HistogramData::Histogram &lhs, const
 
 void Multiply::setOutputUnits(const API::MatrixWorkspace_const_sptr lhs, const API::MatrixWorkspace_const_sptr rhs,
                               API::MatrixWorkspace_sptr out) {
-  if (!lhs->isDistribution() || !rhs->isDistribution())
+  if (!lhs->isDistribution() || !rhs->isDistribution()) {
     out->setDistribution(false);
+  }
 }
 
 // ===================================== EVENT LIST BINARY OPERATIONS

Framework/Algorithms/test/MultiplyDivideTest.in.h

@@ -1050,6 +1050,8 @@ class @MULTIPLYDIVIDETEST_CLASS@ : public CxxTest::TestSuite
     auto rhs = create_RaggedWorkspace();
     auto result = performTest(lhs, rhs, false, DO_DIVIDE ? 1.0 : 4.0, DO_DIVIDE ? 1.4142135625 : 5.6568542436);
     TS_ASSERT(result->isRaggedWorkspace());
+    TS_ASSERT_EQUALS(result->isDistribution(), DO_DIVIDE ? true : false);
+    TS_ASSERT(result->YUnit().empty());
   }
 
   void test_RaggedWorkspace_and_single_value()

docs/source/release/v6.12.0/Framework/Algorithms/Bugfixes/38487.rst

@@ -0,0 +1 @@
+- Corrects `isDistribution` property of result of division of two ragged workspaces, now `true`