Merge pull request #38445 from peterfpeterson/gcc13_ornlnext

Update gcc to version 13 - ornlnext

Author: peterfpeterson

Framework/API/test/CMakeLists.txt

@@ -1,5 +1,5 @@
 if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
-  add_compile_options(-Wno-maybe-uninitialized)
+  add_compile_options(-Wno-uninitialized)
 endif()
 
 if(CXXTEST_FOUND)

Framework/Algorithms/src/FitPeaks.cpp

@@ -34,6 +34,7 @@
 #include "MantidKernel/ListValidator.h"
 #include "MantidKernel/StartsWithValidator.h"
 #include "MantidKernel/VectorHelper.h"
+#include "MantidKernel/WarningSuppressions.h"
 
 #include "boost/algorithm/string.hpp"
 #include "boost/algorithm/string/trim.hpp"
@@ -2118,6 +2119,8 @@ size_t FitPeaks::histRangeToDataPointCount(size_t iws, const std::pair<double, d
   return number_dp;
 }
 
+GNU_DIAG_OFF("dangling-reference")
+
 //----------------------------------------------------------------------------------------------
 /** Convert a histogram range to vector index boundaries
  * @param iws :: histogram index in workspace
@@ -2172,6 +2175,8 @@ void FitPeaks::getRangeData(size_t iws, const std::pair<double, double> &range,
   std::copy(orig_e.begin() + left_index, orig_e.begin() + left_index + num_datapoints, vec_e.begin());
 }
 
+GNU_DIAG_ON("dangling-reference")
+
 //----------------------------------------------------------------------------------------------
 /** Calculate signal-to-noise ratio in a histogram range
  * @param iws :: histogram index in workspace

Framework/Algorithms/src/SofQWCentre.cpp

@@ -13,6 +13,7 @@
 #include "MantidGeometry/Instrument.h"
 #include "MantidGeometry/Instrument/DetectorInfo.h"
 #include "MantidKernel/PhysicalConstants.h"
+#include "MantidKernel/WarningSuppressions.h"
 
 namespace Mantid::Algorithms {
 
@@ -27,6 +28,8 @@ using namespace API;
  */
 void SofQWCentre::init() { SofQW::createCommonInputProperties(*this); }
 
+GNU_DIAG_OFF("dangling-reference")
+
 void SofQWCentre::exec() {
   using namespace Geometry;
   using PhysicalConstants::E_mev_toNeutronWavenumberSq;
@@ -150,6 +153,8 @@ void SofQWCentre::exec() {
     prog.report();
   }
 
+  GNU_DIAG_ON("dangling-reference")
+
   // If the input workspace was a distribution, need to divide by q bin width
   if (inputWorkspace->isDistribution())
     this->makeDistribution(*outputWorkspace, verticalAxis);

Framework/Algorithms/test/CMakeLists.txt

@@ -1,5 +1,5 @@
 if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
-  add_compile_options(-Wno-maybe-uninitialized)
+  add_compile_options(-Wno-uninitialized)
 endif()
 
 if(CXXTEST_FOUND)

Framework/Algorithms/test/CalculateCarpenterSampleCorrectionTest.h

@@ -18,6 +18,7 @@
 #include "MantidFrameworkTestHelpers/WorkspaceCreationHelper.h"
 #include "MantidHistogramData/LinearGenerator.h"
 #include "MantidIndexing/IndexInfo.h"
+#include "MantidKernel/WarningSuppressions.h"
 
 using namespace Mantid;
 using namespace Mantid::API;
@@ -189,6 +190,8 @@ class CalculateCarpenterSampleCorrectionTest : public CxxTest::TestSuite {
     AnalysisDataService::Instance().remove("TestOutputWS");
   }
 
+  GNU_DIAG_OFF("dangling-reference")
+
   void testCalculationEvent() {
     const std::string outName("CalculateCarpenterSampleCorrectionEventOutput");
 
@@ -255,6 +258,8 @@ class CalculateCarpenterSampleCorrectionTest : public CxxTest::TestSuite {
     AnalysisDataService::Instance().remove(outName);
   }
 
+  GNU_DIAG_ON("dangling-reference")
+
 private:
   Mantid::Algorithms::CalculateCarpenterSampleCorrection algorithm;
 };

Framework/Algorithms/test/CarpenterSampleCorrectionTest.h

@@ -18,6 +18,7 @@
 #include "MantidFrameworkTestHelpers/WorkspaceCreationHelper.h"
 #include "MantidHistogramData/LinearGenerator.h"
 #include "MantidIndexing/IndexInfo.h"
+#include "MantidKernel/WarningSuppressions.h"
 
 using namespace Mantid;
 using namespace Mantid::API;
@@ -64,6 +65,8 @@ class CarpenterSampleCorrectionTest : public CxxTest::TestSuite {
     TS_ASSERT(dynamic_cast<PropertyWithValue<double> *>(props[5]));
   }
 
+  GNU_DIAG_OFF("dangling-reference")
+
   void testCalculationHist() {
     using namespace Mantid::HistogramData;
     auto wksp = DataObjects::create<DataObjects::Workspace2D>(
@@ -154,6 +157,8 @@ class CarpenterSampleCorrectionTest : public CxxTest::TestSuite {
       TS_ASSERT_LESS_THAN(y_actual[i], 6.66480);
     }
 
+    GNU_DIAG_ON("dangling-reference")
+
     // cleanup
     AnalysisDataService::Instance().remove(outName);
   }

Framework/Algorithms/test/FitPeaksTest.h

@@ -20,6 +20,7 @@
 #include "MantidFrameworkTestHelpers/WorkspaceCreationHelper.h"
 #include "MantidKernel/Logger.h"
 #include "MantidKernel/UnitFactory.h"
+#include "MantidKernel/WarningSuppressions.h"
 
 using Mantid::Algorithms::FitPeaks;
 
@@ -34,6 +35,8 @@ using Mantid::HistogramData::Counts;
 using Mantid::HistogramData::CountStandardDeviations;
 using Mantid::HistogramData::Points;
 
+GNU_DIAG_OFF("dangling-reference")
+
 namespace {
 /// static Logger definition
 Logger g_log("FitPeaksTest");

Framework/Algorithms/test/NormaliseToMonitorTest.h

@@ -20,6 +20,7 @@
 #include "MantidHistogramData/LinearGenerator.h"
 #include "MantidIndexing/IndexInfo.h"
 #include "MantidKernel/UnitFactory.h"
+#include "MantidKernel/WarningSuppressions.h"
 
 using namespace Mantid;
 using namespace Mantid::Kernel;
@@ -404,6 +405,8 @@ class NormaliseToMonitorTest : public CxxTest::TestSuite {
     TS_ASSERT(alg.isExecuted())
   }
 
+  GNU_DIAG_OFF("dangling-reference")
+
   void test_with_scanning_workspace_bin_by_bin() {
     auto testWS = makeTestDetectorScanWorkspace();
 
@@ -504,6 +507,8 @@ class NormaliseToMonitorTest : public CxxTest::TestSuite {
     }
   }
 
+  GNU_DIAG_ON("dangling-reference")
+
 private:
   MatrixWorkspace_sptr makeTestDetectorScanWorkspace() {
     const size_t N_DET = 10;

Framework/Beamline/src/ComponentInfo.cpp

@@ -314,7 +314,7 @@ void ComponentInfo::doScaleComponent(const std::pair<size_t, size_t> &index, con
     const size_t offsetIndex = compOffsetIndex(subIndex);
     Eigen::Vector3d oldPos = position({subIndex, timeIndex});
     Eigen::Vector3d newPos = scalingMatrix * oldPos + (Eigen::Matrix3d::Identity() - scalingMatrix) * compPos;
-    m_positions.access()[linearIndex({offsetIndex, timeIndex})] = newPos;
+    m_positions.access()[linearIndex({offsetIndex, timeIndex})] = std::move(newPos);
   }
 }
 

Framework/Crystal/src/SCDPanelErrors.cpp

@@ -17,6 +17,7 @@
 #include "MantidGeometry/Instrument.h"
 #include "MantidGeometry/Instrument/Component.h"
 #include "MantidGeometry/Instrument/RectangularDetector.h"
+#include "MantidKernel/DynamicPointerCastHelper.h"
 #include "MantidKernel/FileValidator.h"
 #include <algorithm>
 #include <boost/math/special_functions/round.hpp>
@@ -76,7 +77,9 @@ void SCDPanelErrors::moveDetector(double x, double y, double z, double rotx, dou
   if (detname.compare("none") == 0.0)
     return;
   // CORELLI has sixteenpack under bank
-  DataObjects::PeaksWorkspace_sptr inputP = std::dynamic_pointer_cast<DataObjects::PeaksWorkspace>(inputW);
+  DataObjects::PeaksWorkspace_sptr inputP =
+      Kernel::DynamicPointerCastHelper::dynamicPointerCastWithCheck<DataObjects::PeaksWorkspace, API::Workspace>(
+          inputW);
   Geometry::Instrument_sptr inst = std::const_pointer_cast<Geometry::Instrument>(inputP->getInstrument());
   if (inst->getName().compare("CORELLI") == 0.0 && detname != "moderator")
     detname.append("/sixteenpack");
@@ -175,15 +178,9 @@ void SCDPanelErrors::eval(double xshift, double yshift, double zshift, double xr
   std::shared_ptr<API::Workspace> cloned = m_workspace->clone();
   moveDetector(xshift, yshift, zshift, xrotate, yrotate, zrotate, scalex, scaley, m_bank, cloned);
 
-  auto inputP = std::dynamic_pointer_cast<DataObjects::PeaksWorkspace>(cloned);
-  // IAlgorithm_sptr alg =
-  //     Mantid::API::AlgorithmFactory::Instance().create("IndexPeaks", -1);
-  // alg->initialize();
-  // alg->setChild(true);
-  // alg->setLogging(false);
-  // alg->setProperty("PeaksWorkspace", inputP);
-  // alg->setProperty("Tolerance", 0.15);
-  // alg->execute();
+  auto inputP =
+      Kernel::DynamicPointerCastHelper::dynamicPointerCastWithCheck<DataObjects::PeaksWorkspace, API::Workspace>(
+          cloned);
   auto inst = inputP->getInstrument();
   Geometry::OrientedLattice lattice = inputP->mutableSample().getOrientedLattice();
   for (int i = 0; i < inputP->getNumberPeaks(); i++) {