Merge pull request #38342 from mantidproject/38335_clang_18

Update Clang to version 18 on macOS

Author: SilkeSchomann

Framework/CurveFitting/src/Functions/BSpline.cpp

@@ -61,14 +61,14 @@ void BSpline::resetValidators() {
   auto attStartX = getAttribute("StartX");
   auto attEndX = getAttribute("EndX");
 
-  auto startXValidator = dynamic_cast<BoundedValidator<double> *>(attStartX.getValidator().get());
+  auto startXValidator = std::dynamic_pointer_cast<BoundedValidator<double>>(attStartX.getValidator());
   startXValidator->setUpper(attEndX.asDouble());
 
-  auto endXValidator = dynamic_cast<BoundedValidator<double> *>(attEndX.getValidator().get());
+  auto endXValidator = std::dynamic_pointer_cast<BoundedValidator<double>>(attEndX.getValidator());
   endXValidator->setLower(attStartX.asDouble());
 
   auto breakPointsValidator =
-      dynamic_cast<ArrayBoundedValidator<double> *>(getAttribute("BreakPoints").getValidator().get());
+      std::dynamic_pointer_cast<ArrayBoundedValidator<double>>(getAttribute("BreakPoints").getValidator());
   breakPointsValidator->setLower(attStartX.asDouble());
   breakPointsValidator->setUpper(attEndX.asDouble());
 }

buildconfig/CMake/CommonSetup.cmake

@@ -130,6 +130,7 @@ endif()
 # ######################################################################################################################
 set(CMAKE_CXX_STANDARD 20)
 set(CMAKE_CXX_STANDARD_REQUIRED ON)
+set(CMAKE_CXX_EXTENSIONS OFF)
 
 # ######################################################################################################################
 # Setup ccache

buildconfig/CMake/GNUSetup.cmake

@@ -72,6 +72,7 @@ elseif("${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang")
   add_definitions(-D_LIBCPP_DISABLE_AVAILABILITY)
   # Keep C++14 alignment behaviour while older macOS C++ ABI does not contain the required symbols. Minimum=macos 10.14
   add_compile_options(-fno-aligned-new)
+  add_compile_options(-fno-assume-unique-vtables)
 endif()
 
 # Add some options for debug build to help the Zoom profiler

conda/recipes/conda_build_config.yaml

@@ -5,17 +5,17 @@ c_compiler:
   - clang                    # [osx]
   - vs2019                   # [win]
 c_compiler_version:            # [unix]
-  - 16                         # [osx]
+  - 18                         # [osx]
   - 13                         # [linux]
 cxx_compiler:
   - gxx                      # [linux]
   - clangxx                  # [osx]
   - vs2019                   # [win]
 cxx_compiler_version:          # [unix]
-  - 16                         # [osx]
+  - 18                         # [osx]
   - 13                         # [linux]
 llvm_openmp:                   # [osx]
-  - 16                         # [osx]
+  - 18                         # [osx]
 
 python:
   - 3.10

docs/source/release/v6.12.0/Workbench/New_features/38335.rst

@@ -0,0 +1 @@
+- Updated compiler on macOS from version 16 to version 18, which should result in performance improvements. See https://releases.llvm.org for release notes.