satisfy cppcheck - remove std::move to allow for nrvo

MialLewis · MialLewis · commit a0347126b83b · 2025-04-24T12:06:46.000+01:00
diff --git a/Framework/Kernel/src/FilteredTimeSeriesProperty.cpp b/Framework/Kernel/src/FilteredTimeSeriesProperty.cpp
@@ -413,7 +413,7 @@ Kernel::TimeROI *FilteredTimeSeriesProperty<TYPE>::intersectFilterWithOther(cons
   auto roi = new TimeROI(*m_filter.get());
   if (other && (!other->useAll()))
     roi->update_or_replace_intersection(*other);
-  return std::move(roi);
+  return roi;
 }
 
 template <typename TYPE> const Kernel::TimeROI &FilteredTimeSeriesProperty<TYPE>::getTimeROI() const {

Original file line number	Diff line number	Diff line change
`@@ -413,7 +413,7 @@ Kernel::TimeROI *FilteredTimeSeriesProperty<TYPE>::intersectFilterWithOther(cons`
`413`	`413`	`auto roi = new TimeROI(*m_filter.get());`
`414`	`414`	`if (other && (!other->useAll()))`
`415`	`415`	`roi->update_or_replace_intersection(*other);`
`416`		`- return std::move(roi);`
	`416`	`+ return roi;`
`417`	`417`	`}`
`418`	`418`
`419`	`419`	`template <typename TYPE> const Kernel::TimeROI &FilteredTimeSeriesProperty<TYPE>::getTimeROI() const {`