Skip to content

Commit a48b448

Browse files
authored
Merge pull request #37744 from mantidproject/deprecation_removed_release_note_template
Update release notes template and generator
2 parents 2bebd58 + d0339b6 commit a48b448

File tree

4 files changed

+50
-12
lines changed

4 files changed

+50
-12
lines changed

dev-docs/source/Standards/ReleaseNotesGuide.rst

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ Release note files need to be saved in the directory that best represents their
7373
or ``Bugfixes`` directory. For example a Bugfix release note for Engineering Diffraction should sit within ``/Diffraction/Engineering/Bugfixes`` .
7474

7575
Release notes should not be placed in any directory outside of ``New_features`` or ``Bugfixes`` e.g. do not place release notes in ``/Diffraction/Engineering``. You should also not save release notes in any directory titled ``Used`` as this is for notes that have already been collated into the release notes.
76+
The only exception to this is for Algorithms and Fit Functions in the Framework Directory that additionally have ``Deprecated`` and ``Removed``.
7677

7778
If you are uncertain where your release note should be see the :ref:`Standard File Structure <ReleaseNoteFileStructure>`.
7879

@@ -191,11 +192,15 @@ This is the basic directory structure that is available to you for release notes
191192

192193
+ New features
193194
+ Bugfixes
195+
+ Deprecated
196+
+ Removed
194197

195198
- Fit Functions (Sub-heading)
196199

197200
+ New features
198201
+ Bugfixes
202+
+ Deprecated
203+
+ Removed
199204

200205
- Data Objects (Sub-heading)
201206

docs/source/conf.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,4 +237,11 @@ def setup(app):
237237
# Suppress build warnings of the type:
238238
# "WARNING: document isn't included in any toctree"
239239
# for individual release notes files.
240-
exclude_patterns = ["release/templates/*.rst", "release/**/Bugfixes/*.rst", "release/**/New_features/*.rst", "release/**/Used/*.rst"]
240+
exclude_patterns = [
241+
"release/templates/*.rst",
242+
"release/**/Bugfixes/*.rst",
243+
"release/**/New_features/*.rst",
244+
"release/**/Used/*.rst",
245+
"release/**/Removed/*.rst",
246+
"release/**/Deprecated/*.rst",
247+
]

docs/source/release/templates/framework.rst

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,14 @@ Bugfixes
1616
############
1717
.. amalgamate:: Framework/Algorithms/Bugfixes
1818

19+
Deprecated
20+
############
21+
.. amalgamate:: Framework/Algorithms/Deprecated
22+
23+
Removed
24+
############
25+
.. amalgamate:: Framework/Algorithms/Removed
26+
1927
Fit Functions
2028
-------------
2129

@@ -27,6 +35,14 @@ Bugfixes
2735
############
2836
.. amalgamate:: Framework/Fit_Functions/Bugfixes
2937

38+
Deprecated
39+
############
40+
.. amalgamate:: Framework/Fit_Functions/Deprecated
41+
42+
Removed
43+
############
44+
.. amalgamate:: Framework/Fit_Functions/Removed
45+
3046

3147
Data Objects
3248
------------

tools/release_generator/release.py

Lines changed: 21 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,7 @@
131131
muon = ["FDA", "Muon_Analysis", "MA_FDA", "ALC", "Elemental_Analysis", "Algorithms"]
132132

133133
subfolders = ["Bugfixes", "New_features"]
134+
deprecated_subfolders = subfolders + ["Deprecated", "Removed"]
134135
muon_subfolders = ["Bugfixes"]
135136
#################################################################################
136137

@@ -225,18 +226,27 @@ def makeSubDirectoriesFromList(directoryList, upperDirectory, HigherLevel):
225226
makeReleaseNoteSubfolders(combinedDirectory, HigherLevel)
226227

227228

228-
def makeReleaseNoteSubfolders(directory, HigherLevel):
229+
def subfolder_creation(directory, HigherLevel, folder):
230+
subfolderName = HigherLevel / directory / folder
231+
subfolderName.mkdir(parents=True, exist_ok=True)
232+
makeGitkeep(subfolderName)
233+
234+
235+
def getSubfoldersForDirectory(directory):
229236
directoryStr = str(directory)
230-
for folder in subfolders:
231-
if "Muon" in directoryStr:
232-
for single_folder in muon_subfolders:
233-
subfolderName = HigherLevel / directory / single_folder
234-
subfolderName.mkdir(parents=True, exist_ok=True)
235-
makeGitkeep(subfolderName)
236-
else:
237-
subfolderName = HigherLevel / directory / folder
238-
subfolderName.mkdir(parents=True, exist_ok=True)
239-
makeGitkeep(subfolderName)
237+
238+
if "Muon" in directoryStr:
239+
return muon_subfolders
240+
241+
if "Framework" in directoryStr and ("Algorithm" in directoryStr or "Fit_Functions" in directoryStr):
242+
return deprecated_subfolders
243+
244+
return subfolders
245+
246+
247+
def makeReleaseNoteSubfolders(directory, HigherLevel):
248+
for folder in getSubfoldersForDirectory(directory):
249+
subfolder_creation(directory, HigherLevel, folder)
240250

241251

242252
def makeGitkeep(subfolderName):

0 commit comments

Comments
 (0)