subsequent cppcheck fixes

Author: jhaigh0

Framework/API/inc/MantidAPI/MDGeometry.h

@@ -80,7 +80,7 @@ class MANTID_API_DLL MDGeometry {
   Mantid::API::CoordTransform const *getTransformToOriginal(size_t index = 0) const;
   void setTransformToOriginal(Mantid::API::CoordTransform *transform, size_t index = 0);
 
-  void transformDimensions(std::vector<double> &scaling, std::vector<double> &offset);
+  void transformDimensions(const std::vector<double> &scaling, const std::vector<double> &offset);
 
   size_t getNumberTransformsToOriginal() const;
   size_t getNumberTransformsFromOriginal() const;

Framework/API/src/LogManager.cpp

@@ -215,7 +215,6 @@ const DateAndTime LogManager::getFirstPulseTime() const {
   const DateAndTime reference("1991-01-01T00:00:00");
   const std::vector<DateAndTime> &times = log->timesAsVector();
   const size_t maxSkip{100};
-  size_t index;
   const size_t maxIndex = std::min(static_cast<size_t>(log->realSize()), maxSkip);
   const auto it = std::find_if(times.cbegin(), times.cbegin() + maxIndex,
                                [&reference](const auto &time) { return time >= reference; });

Framework/API/src/MDGeometry.cpp

@@ -396,7 +396,7 @@ void MDGeometry::setOriginalWorkspace(std::shared_ptr<Workspace> ws, size_t inde
  * @param scaling :: multiply each coordinate by this value.
  * @param offset :: after multiplying, add this offset.
  */
-void MDGeometry::transformDimensions(std::vector<double> &scaling, std::vector<double> &offset) {
+void MDGeometry::transformDimensions(const std::vector<double> &scaling, const std::vector<double> &offset) {
   if (scaling.size() != m_dimensions.size())
     throw std::invalid_argument("MDGeometry::transformDimensions(): "
                                 "scaling.size() must be equal to number of "

Framework/API/src/Run.cpp

@@ -361,7 +361,7 @@ void Run::integrateProtonCharge(const std::string &logname) const {
     } else {
       const auto &times = log->timesAsVector();
 
-      total = std::accumulate(times.cbegin(), times.cend(), 0., [&](double valueTotal, DateAndTime &time) {
+      total = std::accumulate(times.cbegin(), times.cend(), 0., [&](double valueTotal, const DateAndTime &time) {
         return timeroi.valueAtTime(time) ? total + log->getSingleValue(time) : total;
       });
     }

buildconfig/CMake/CppCheck_Suppressions.txt.in

@@ -78,7 +78,6 @@ constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/API/src/IPeaksWorkspace.cpp:5
 operatorEqVarError:${CMAKE_SOURCE_DIR}/Framework/API/src/ISpectrum.cpp:156
 operatorEqVarError:${CMAKE_SOURCE_DIR}/Framework/API/src/ISpectrum.cpp:167
 constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/API/src/ITableWorkspace.cpp:118
-constParameterReference:${CMAKE_SOURCE_DIR}/Framework/API/src/MDGeometry.cpp:395
 constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/API/src/MatrixWorkspaceMDIterator.cpp:100
 constVariableReference:${CMAKE_SOURCE_DIR}/Framework/API/src/MultiDomainFunction.cpp:135
 constVariableReference:${CMAKE_SOURCE_DIR}/Framework/API/src/MultiDomainFunction.cpp:174
@@ -120,7 +119,6 @@ constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/ExportTimeSeri
 constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/ExportTimeSeriesLog.cpp:330
 constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/FilterByLogValue.cpp:82
 constVariableReference:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/FilterEvents.cpp:304
-constParameterReference:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/FindPeakBackground.cpp:272
 knownConditionTrueFalse:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/FindPeaks.cpp:892
 knownConditionTrueFalse:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/FindPeaks.cpp:999
 shadowVariable:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/FitPeak.cpp:1399