Skip to content

Commit ab80ee4

Browse files
authored
Move function contents from napi5 to NexusFile (#39484)
### Description of work The following have been identified as simple enough that they can be directly copied into corresponding NexusFile method with minimal further refactoring - NX5makegroup() --> File::makeGroup() - NX5opengroup() --> File::openGroup() - NX5closegroup() --> File::closeGroup() - NX5compmakedata64() --> File::makeCompData() - NX5opendata() --> File::openData() - NX5putdata() --> File::putData(NumT const *data)  (there are many, here signature matters) - NX5closedata() --> File::closeData() - NX5putslab64() --> File::putSlab(NumT const *data, DimSizeVector const &start, DimSizeVector const &size) (this signature) - NX5getslab64() --> File::getSlab() - NX5makelink() --> File::makeLink() - NX5getdataID() --> File::getDataID() - NX5getgroupID() --> File::getGroupID() - NX5flush() --> File::flush() Relates to [EWM 11786](https://ornlrse.clm.ibmcloud.com/ccm/web/projects/Neutron%20Data%20Project%20%28Change%20Management%29#action=com.ibm.team.workitem.viewWorkItem&id=11786) ### To test: This is moving functionality from `napi5.cpp` to `NexusFile.cpp` so all existing tests should pass. <!-- Instructions for testing. There should be sufficient instructions for someone unfamiliar with the application to test - unless a specific reviewer is requested. If instructions for replicating the fault are contained in the linked issue then it is OK to refer back to these. --> *This does not require release notes* because **it is an internal change only with no change to functionality** <!-- delete this if you added release notes *This does not require release notes* because **fill in an explanation of why** If you add release notes please save them as a separate file using the Issue or PR number as the file name. Check the file is located in the correct directory for your note(s). --> <!-- Ensure the base of this PR is correct (e.g. release-next or main) Finally, don't forget to add the appropriate labels, milestones, etc.! --> --- ### Reviewer Please comment on the points listed below ([full description](http://developer.mantidproject.org/ReviewingAPullRequest.html)). **Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review.** If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed. #### Code Review - Is the code of an acceptable quality? - Does the code conform to the [coding standards](http://developer.mantidproject.org/Standards/)? - Are the unit tests small and test the class in isolation? - If there is GUI work does it follow the [GUI standards](http://developer.mantidproject.org/Standards/GUIStandards.html)? - If there are changes in the release notes then do they describe the changes appropriately? - Do the release notes conform to the [release notes guide](https://developer.mantidproject.org/Standards/ReleaseNotesGuide.html)? #### Functional Tests - Do changes function as described? Add comments below that describe the tests performed? - Do the changes handle unexpected situations, e.g. bad input? - Has the relevant (user and developer) documentation been added/updated? Does everything look good? Mark the review as **Approve**. A member of `@mantidproject/gatekeepers` will take care of it. ### Gatekeeper If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.
1 parent 158045c commit ab80ee4

File tree

8 files changed

+824
-42
lines changed

8 files changed

+824
-42
lines changed

Framework/Nexus/CMakeLists.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,10 @@ set(TEST_FILES
2525
NexusIOHelperTest.h
2626
NexusClassesTest.h
2727
NexusDescriptorTest.h
28-
NeXusFileTest.h
29-
NeXusFileLeakTest.h
30-
NeXusFileNapiTest.h
31-
NeXusFileReadWriteTest.h
28+
NexusFileTest.h
29+
NexusFileLeakTest.h
30+
NexusFileNapiTest.h
31+
NexusFileReadWriteTest.h
3232
NapiUnitTest.h
3333
)
3434

Framework/Nexus/inc/MantidNexus/NexusFile.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -646,7 +646,7 @@ class MANTID_NEXUS_DLL File {
646646
*
647647
* \param link The object (group or data) in the file to link to.
648648
*/
649-
void makeLink(NXlink &link);
649+
void makeLink(NXlink const &link);
650650
};
651651

652652
/**

0 commit comments

Comments
 (0)