Skip to content

Commit b2acf19

Browse files
committed
remove do-nothing void cast, release notes
1 parent 352eea1 commit b2acf19

File tree

2 files changed

+4
-4
lines changed
  • Framework/DataObjects/inc/MantidDataObjects
  • docs/source/release/v6.12.0/Framework/Algorithms/Bugfixes

2 files changed

+4
-4
lines changed

Framework/DataObjects/inc/MantidDataObjects/TableColumn.h

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -274,9 +274,8 @@ template <class Type> class TableColumn : public API::Column {
274274

275275
/// Template specialisation for strings for comparison
276276
template <>
277-
inline bool TableColumn<std::string>::compareVectors(const std::vector<std::string> &newVector, double tolerance,
277+
inline bool TableColumn<std::string>::compareVectors(const std::vector<std::string> &newVector, double,
278278
bool const) const {
279-
(void)tolerance;
280279
for (size_t i = 0; i < m_data.size(); i++) {
281280
if (m_data[i] != newVector[i]) {
282281
return false;
@@ -287,9 +286,8 @@ inline bool TableColumn<std::string>::compareVectors(const std::vector<std::stri
287286

288287
/// Template specialisation for strings for comparison
289288
template <>
290-
inline bool TableColumn<API::Boolean>::compareVectors(const std::vector<API::Boolean> &newVector, double tolerance,
289+
inline bool TableColumn<API::Boolean>::compareVectors(const std::vector<API::Boolean> &newVector, double,
291290
bool const) const {
292-
(void)tolerance;
293291
for (size_t i = 0; i < m_data.size(); i++) {
294292
if (!(m_data[i] == newVector[i])) {
295293
return false;
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
- fixes bug in :ref:`CompareWorkspaces <algm-CompareWorkspaces>` that evaluated ``NaN`` values as equal to any floating point (including ``inf`` and finite values).
2+
- adds new flag NaNsEqual to :ref:`CompareWorkspaces <algm-CompareWorkspaces>` to control how ``NaN`` compares to other ``NaN`` s.

0 commit comments

Comments
 (0)