Skip to content

Commit cfca0ee

Browse files
peterfpetersonpre-commit-ci[bot]thomashampson
authored
Update numpy pinning strategy (#39875)
This pulls a couple of changes into `ornl-next` * #39865 * #39803 * #39871 --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: thomashampson <thomas.hampson@stfc.ac.uk>
1 parent 93c6dbe commit cfca0ee

File tree

5 files changed

+10
-10
lines changed

5 files changed

+10
-10
lines changed

.pre-commit-config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ repos:
5959
)$
6060
6161
- repo: https://github.com/astral-sh/ruff-pre-commit
62-
rev: v0.12.9
62+
rev: v0.12.10
6363
# ruff must appear before black in the list of hooks
6464
hooks:
6565
- id: ruff-check

conda/recipes/conda_build_config.yaml

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ hdf5: # this is to move to libcurl>=8.4
4747
graphviz:
4848
- '>=2.47.0'
4949

50-
# this must match the version in the developer dependencies
5150
jemalloc:
5251
- 5.2.0 # [linux]
5352
- 5.2.* # [osx]
@@ -58,13 +57,13 @@ jsoncpp:
5857
libglu:
5958
- '>=9.0'
6059

61-
#v2.8.5 caused seg faults on Mantid conda versions and large numbers of tests failing
60+
#v2.3.5 caused seg faults on Mantid conda versions and large numbers of tests failing
6261
muparser:
6362
- '>=2.3.2, <2.3.5'
6463

65-
# We follow conda-forge and build with the lowest supported version of numpy for forward compatibility.
64+
# Aim to build using the latest minor version, and rely on numpy's generous backward compatibility.
6665
numpy:
67-
- 2.0.*
66+
- 2.1.*
6867

6968
matplotlib:
7069
- 3.9.*
@@ -169,5 +168,8 @@ versioningit:
169168
- '>=2.1'
170169

171170
pin_run_as_build:
172-
boost:
173-
max_pin: x.x
171+
boost:
172+
max_pin: x.x
173+
numpy:
174+
min_pin: x
175+
max_pin: x.x

conda/recipes/mantid-developer/meta.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ requirements:
3030
- matplotlib {{ matplotlib }}
3131
- muparser {{ muparser }}
3232
- ninja {{ ninja }}
33-
- numpy>=2.0,<2.2 # This is intentionally different to conda_build_config.yaml, will address later.
33+
- numpy {{ numpy }}
3434
- occt {{ occt }}
3535
- pip {{ pip }}
3636
- poco {{ poco }}

conda/recipes/mantid/meta.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@ requirements:
6363
- jemalloc {{ jemalloc }} # [osx or linux]
6464
- lib3mf # [win]
6565
- muparser {{ muparser }}
66-
- {{ pin_compatible("numpy", upper_bound="2.2") }}
6766
- occt {{ occt }}
6867
- pycifrw
6968
- pydantic {{ pydantic }}

installers/conda/win/create_package.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,6 @@ mv $CONDA_ENV_PATH/Library/mingw-w64/bin/libgcc_s_seh*.dll $COPY_DIR/bin/
115115

116116
echo "Copy Mantid specific files from env/Library/bin to package/bin"
117117
mv $CONDA_ENV_PATH/Library/bin/Mantid.properties $COPY_DIR/bin/
118-
mv $CONDA_ENV_PATH/Library/bin/MantidNexusParallelLoader.exe $COPY_DIR/bin/
119118
mv $CONDA_ENV_PATH/Library/bin/mantid-scripts.pth $COPY_DIR/bin/
120119

121120
echo "Copy Mantid icon files from source to package/bin"

0 commit comments

Comments
 (0)