Skip to content

Commit e9b19c5

Browse files
Do not download all data to run system tests (#39980)
For developers that haven't already pulled down the unit test data, it is very slow to download the data. Since system tests should only depend on system test data, modify the launch scripts to only build that target. Also add a dependency that docs-html on DocTestData. There is no associated issue. Part of [EWM13216](https://ornlrse.clm.ibmcloud.com/ccm/web/projects/Neutron%20Data%20Project%20(Change%20Management)#action=com.ibm.team.workitem.viewWorkItem&id=13216). This is originally split off from #39154. ### To test: A proper test is ```sh ninja clean && ninja ./systemtest ``` but you might be happier just looking through the changeset.
1 parent 5d6fc7d commit e9b19c5

File tree

3 files changed

+1
-5
lines changed

3 files changed

+1
-5
lines changed

Testing/SystemTests/scripts/systemtest.bat.in

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,13 +53,9 @@ if "%MULTI_CONFIG_GENERATOR%" == "true" (
5353
:: Update testing data
5454
echo Updating testing data...
5555
if "%MULTI_CONFIG_GENERATOR%" == "true" (
56-
cmake --build . --target StandardTestData --config %2
57-
if ERRORLEVEL 1 exit /b %ERRORLEVEL%
5856
cmake --build . --target SystemTestData --config %2
5957
if ERRORLEVEL 1 exit /b %ERRORLEVEL%
6058
) else (
61-
cmake --build . --target StandardTestData
62-
if ERRORLEVEL 1 exit /b %ERRORLEVEL%
6359
cmake --build . --target SystemTestData
6460
if ERRORLEVEL 1 exit /b %ERRORLEVEL%
6561
)

Testing/SystemTests/scripts/systemtest.in

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ if [ $(command -v cmake3) ]; then
7373
else
7474
CMAKE_EXE=cmake
7575
fi
76-
$CMAKE_EXE --build . $CMAKE_TARGET_ARG -- StandardTestData
7776
$CMAKE_EXE --build . $CMAKE_TARGET_ARG -- SystemTestData
7877

7978
# Execute

docs/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,7 @@ endfunction()
108108

109109
# Documentation types
110110
add_sphinx_build_target(html "sphinx.ext.mathjax")
111+
add_dependencies(docs-html DocTestData)
111112
add_sphinx_build_target(doctest "sphinx.ext.mathjax")
112113
add_dependencies(docs-doctest DocTestData)
113114

0 commit comments

Comments
 (0)