Skip to content

Commit fca7b75

Browse files
authored
Merge pull request #37858 from mantidproject/ewm6854-ornl-next
add ConfigService::remove to python API - `ornl-next`
2 parents 8bdca46 + 3a32f69 commit fca7b75

File tree

3 files changed

+10
-0
lines changed

3 files changed

+10
-0
lines changed

Framework/PythonInterface/mantid/kernel/src/Exports/ConfigService.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,7 @@ void export_ConfigService() {
104104
"definitions")
105105
.def("getFacilityNames", &ConfigServiceImpl::getFacilityNames, arg("self"), "Returns the default facility")
106106
.def("getFacilities", &ConfigServiceImpl::getFacilities, arg("self"), "Returns the default facility")
107+
.def("remove", &ConfigServiceImpl::remove, (arg("self"), arg("rootName")), "Remove the indicated key.")
107108
.def("getFacility", (const FacilityInfo &(ConfigServiceImpl::*)() const) & ConfigServiceImpl::getFacility,
108109
arg("self"), return_value_policy<reference_existing_object>(), "Returns the default facility")
109110
.def("getFacility",

Framework/PythonInterface/test/python/mantid/kernel/ConfigServiceTest.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -221,6 +221,14 @@ def test_contains(self):
221221
# verify check for converting checked value to string
222222
self.assertFalse(1 in ConfigService)
223223

224+
def test_remove(self):
225+
garbage = "garbage.truck"
226+
assert garbage not in list(config.keys())
227+
config.setString(garbage, "yes")
228+
assert garbage in list(config.keys())
229+
config.remove(garbage)
230+
assert garbage not in list(config.keys())
231+
224232
@unittest.skipIf(not _on_windows, "Windows only test, uses APPDATA")
225233
def test_get_app_data_dir(self):
226234
self.assertEqual(
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
- expose :class:`ConfigService::remove() <mantid.kernel.ConfigServiceImpl.remove>` to python API

0 commit comments

Comments
 (0)