Remove change to BSpline

Author: jhaigh0

Framework/CurveFitting/src/Functions/BSpline.cpp

@@ -141,12 +141,13 @@ size_t BSpline::evaluateBasisFunctions(EigenVector &B, const double x, size_t cu
  */
 size_t BSpline::getSpanIndex(const double x, const size_t currentBBase, const bool clamped) const {
   const size_t clampedKnots = clamped ? static_cast<size_t>(getClampedKnots()) : 1u;
-  const auto it = std::find_if(m_knots.begin() + currentBBase + clampedKnots, m_knots.cend(),
-                               [&x](const size_t knot) { return x < knot; });
-  if (it != m_knots.cend()) {
-    return std::distance(m_knots.cbegin(), it) - clampedKnots;
+  size_t nKnots = m_knots.size();
+  for (size_t i = currentBBase + clampedKnots; i < nKnots; i++) {
+    if (x < m_knots[i]) {
+      return i - clampedKnots;
+    }
   }
-  return m_knots.size() - clampedKnots * 2;
+  return nKnots - clampedKnots * 2;
 }
 
 /** Calculate the derivatives for a set of points on the spline

buildconfig/CMake/CppCheck_Suppressions.txt.in

@@ -188,6 +188,7 @@ constParameterReference:${CMAKE_SOURCE_DIR}/Framework/CurveFitting/src/FuncMinim
 constParameterReference:${CMAKE_SOURCE_DIR}/Framework/CurveFitting/src/FuncMinimizers/FABADAMinimizer.cpp:852
 constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/CurveFitting/src/FuncMinimizers/FABADAMinimizer.cpp:1004
 constParameterReference:${CMAKE_SOURCE_DIR}/Framework/CurveFitting/src/FuncMinimizers/TrustRegionMinimizer.cpp:814
+useStlAlgorithm:${CMAKE_SOURCE_DIR}/Framework/CurveFitting/src/Functions/BSpline.cpp:146
 constParameterReference:${CMAKE_SOURCE_DIR}/Framework/CurveFitting/src/Functions/ChebfunBase.cpp:601
 constParameterReference:${CMAKE_SOURCE_DIR}/Framework/CurveFitting/src/Functions/ChebfunBase.cpp:625
 shadowFunction:${CMAKE_SOURCE_DIR}/Framework/CurveFitting/src/Functions/ChebfunBase.cpp:687