Skip to content

Update PG3StripPeaks to not use AlignDetectors algorithm #37859

@sf1919

Description

@sf1919

Describe the outcome that is desired.
SNSPowderRedux.PG3StripPeaks should no longer use AlignDetectors algorithm.

The proposed change is centered on L219. Currently,

AlignDetectors(InputWorkspace="PG3_4866", OutputWorkspace="PG3_4866", OffsetsWorkspace="PG3_offsets")
ConvertUnits(InputWorkspace="PG3_4866", OutputWorkspace="PG3_4866", Target="TOF")

should become

ApplyDiffCal(InstrumentWorkspace="PG3_4866", OffsetsWorkspace="PG3_offsets")
ConvertUnits(InputWorkspace="PG3_4866", OutputWorkspace="PG3_4866", Target="dSpacing")
ApplyDiffCal(InstrumentWorkspace="PG3_4866", ClearCalibration=True)
ConvertUnits(InputWorkspace="PG3_4866", OutputWorkspace="PG3_4866", Target="TOF")

Additional context
SNSPowderRedux.PG3StripPeaks makes use of the AlignDetectors algorithm. This was deprecated in 2021 (see #30163) and is now being removed as part of #31258. This work is blocking #37799 .

Metadata

Metadata

Labels

High PriorityAn issue or pull request that if not addressed is severe enough to postponse a release.MaintenanceUnassigned issues to be addressed in the next maintenance period.ORNL TeamIssues and pull requests managed by the ORNL development team

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions