-
Notifications
You must be signed in to change notification settings - Fork 128
Description
Describe the outcome that is desired.
There is a lot of logic in the PairingTableView class in the Muon Analysis interface. Ideally the views should be as simple as possible because typically they are untested. Having a simple View also makes it easier to have multiple designs/Views for the same Presenter and Model because the majority of the code that is "doing stuff" is in a different location.
See the logic in this class:
Line 17 in 3afaa63
class PairingTableView(QtWidgets.QWidget): |
To test
Follow the instructions on this page https://developer.mantidproject.org/Testing/MuonAnalysis_test_guides/Muon_Analysis_MUSR.html
(pay close attention to the Pair Table)
Describe any solutions you are considering
We might want to move the logic in this class. The logic should either go in the presenter, model, utility file, or a mixture of all of these depending on what makes the most sense. The logic should not be in the View.
Additional context
- The GroupingTabWidgetView no longer contains logic
- The logic previously in the GroupingTabWidgetView is now tested
Metadata
Metadata
Assignees
Labels
Type
Projects
Status