Fix setuptools deprecations #37775
Merged
Fix setuptools deprecations #37775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jclarkeSTFC
added
Maintenance
|
Unfortunately the package build got a little stuck last night so it needed to be cancelled (it started doing docs tests late last night but hadn't resolved after 6 hours or so). Please can you set off a new package build? |
Replace `python setup.py develop` with `python -m pip install --editable .` This is from the migration instructions online.
This way is much cleaner, plus it will prevent any false positives if the module string is contained within another key. E.g. since moving to pip -m install --editable the editable packages appear in the sys.modules dict, but as something like '__editable_mantidqt_...', but this doesn't mean than mantidqt has been imported.
The workbench file is not going to be generated in the bin folder any more now that we're using pip instead of calling setup.py, but you can just call workbench as a python command, so edit the launch_mantidworkbench script to reflect this.
jclarkeSTFC
force-pushed
the
37277_fix_setuptools_deprecations
branch
from
e6118ec to
57cbc5e
Compare
|
Build works with no setuptools warnings. Windows exe installs correctly with the import working as it should. 👍 Last thing to do will be to check the conda install is okay. |
jhaigh0
approved these changes
Sep 3, 2024
This was referenced Sep 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See here for details about the warning. We were calling
python setup.py develop, but this now seems to be a faux pas, so I've changed it use the recommended alternative.I changed the test because it was giving a false positive, when calling
pip install --editableyou will get something like__editable ... mantidqt ...insys.modules, but that doesn't mean you've importedmantidqt. The test was trying to check that importingmantid.simpleapidoesn't importmantidqt, which it doesn't, you can check this manually pretty quickly at the REPL.Fixes #37277
https://builds.mantidproject.org/job/build_packages_from_branch/870/
To test:
mantid.simpleapiand check thatmantidqtisn't importedThis does not require release notes because it will have no effect on the user
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.