Fix for random phase value bug in PyChop #37805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilkeSchomann
added
Bug
SilkeSchomann
changed the title
mducle
requested changes
Aug 15, 2024
qt/python/mantidqtinterfaces/mantidqtinterfaces/PyChop/PyChopGui.py
Outdated
Show resolved
Hide resolved
mducle
previously approved these changes
Aug 20, 2024
qt/python/mantidqtinterfaces/mantidqtinterfaces/PyChop/PyChopGui.py
Outdated
Show resolved
Hide resolved
mducle
previously approved these changes
Sep 2, 2024
cailafinn
requested changes
Sep 2, 2024
docs/source/release/v6.11.0/Direct_Geometry/General/Bugfixes/37805.rst
Outdated
Show resolved
Hide resolved
…7805.rst Co-authored-by: Caila Finn <47181718+cailafinn@users.noreply.github.com>
cailafinn
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Summary of work
PyChop only allows in "Instrument Scientist Mode" to change the chopper phase and else needs to use the default phase value. For each calculation, the default phase value must be reset to avoid being overwritten by a temporary value when calculating the possible incident energies.
I have also fixed two NumPy deprecation warnings.
Fixes #37734.
Report to: [Adroja / ISIS]
To test:
Follow the instructions in the original issue and check that the bug is fixed.
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.